You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the back arrow icon, subtitle link, and the expand/collapse icon, can we update to indigo/100 from our colors? Reason being to further differentiate them for other nav items.
I don't know if you want to tackle this as part of this PR, but I just want to make sure the icons are all lined up nicely like this screenshot. You might have to play around with spacing. Happy to a pair session on this.
I don't know if you want to tackle this as part of this PR, but I just want to make sure the icons are all lined up nicely like this screenshot. You might have to play around with spacing. Happy to a pair session on this.
Hey @bilal-karim I think that this is something we should talk about. We have been struggling with Icon's lately. Sometimes they seem to be not quite square even after doing the whole download format thing. I think that's why the team brought up the Icon's in the last FEUX meeting. I think we might want to find a better system for getting the Icon's right. The formatting should be consistent on the FE side so really if we can get the Icons to all be exact, It should automatically line up perfectly. Any more thoughts on how to get the icons right? We would appreciate any help you can give us on the icons front for sure. It's a pain point for the whole team.
My personal thoughts are to get the couple of padding tweaks in and then get this in. We can follow up with getting the icons right, unless there's a way to get that done quickly?
I don't know if you want to tackle this as part of this PR, but I just want to make sure the icons are all lined up nicely ...
I'll add a new screenshot with the new icons once I have them in place in Cloud and have linked everything up, then ya'll can judge if they're centered etc. I just wanted to show the dividers initially, next time I'll make a more explicit note about the repo context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New style structure for Contextual Nav
This adds a subtitle that is also a link.
This will allow the subtitles to link back to previous nav contexts.