Updated Recommendation Url to pass through when see_also is empty #43

Author: SteveMcGrath

tenable_aws_sechub/finding.py

@@ -4,9 +4,9 @@
 """
 
 from typing import Dict
-from restfly.utils import dict_flatten, dict_clean, trunc
-import arrow
 
+import arrow
+from restfly.utils import dict_clean, dict_flatten, trunc
 
 SEV_MAP = {0: 0, 1: 3, 2: 5, 3: 7, 4: 10}
 STATE_MAP = {
@@ -153,7 +153,9 @@ def generate(self, vuln: Dict) -> Dict:
                 'Recommendation': {
                     # The solution cannot exceed 1024 characters in length.
                     'Text': trunc(vuln['plugin.solution'], 512),
-                    'Url': vuln.get('plugin.see_also', [])[0],
+                    'Url': vuln.get('plugin.see_also')[0]
+                    if vuln.get('plugin.see_also')
+                    else None,
                 }
             },
             'RecordState': STATE_MAP[vuln['state']],

tenable_aws_sechub/version.py

@@ -1 +1 @@
-version = '2.0.4'
+version = '2.0.5'

tests/test_finding.py

@@ -1,4 +1,5 @@
 import pytest
+
 from tenable_aws_sechub.finding import Finding
 
 
@@ -97,3 +98,12 @@ def test_finding_generate_finding_success(finding_aws):
     finding_aws['state'] = 'FIXED'
     resp = f.generate(finding_aws)
     assert resp['RecordState'] == 'ARCHIVED'
+
+
+def test_generate_finding_none_url(finding_aws):
+    f = Finding('AWS-REGION-1', 'ACCOUNT-ID')
+
+    del finding_aws['plugin.see_also']
+    resp = f.generate(finding_aws)
+
+    assert 'Url' not in resp['Remediation']['Recommendation']