Skip to content

Commit 6a1a417

Browse files
author
zianazhao
committed
[feat]:精简日志
1 parent 461f035 commit 6a1a417

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

pkg/collector/handler_qaap.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ func (h *QaapHandler) getQaapListenerRsSeries(m *metric.TcmMetric, ins instance.
207207
// if err != nil {
208208
// return nil, err
209209
// }
210-
// fmt.Println(ins.GetMonitorQueryKey(), "getTcpSeries耗时", time.Since(start).Milliseconds(), "series", len(series))
211210
// for _, tcpListenersInfo := range tcpListenersInfos.Response.ListenerSet {
212211
// for _, realServerSet := range tcpListenersInfo.RealServerSet {
213212
// ql := map[string]string{
@@ -224,12 +223,10 @@ func (h *QaapHandler) getQaapListenerRsSeries(m *metric.TcmMetric, ins instance.
224223
// series = append(series, s)
225224
// }
226225
// }
227-
// start1 := time.Now()
228226
// udpListenersInfos, err := h.qaapInstanceInfoRepo.GetUDPListenersInfo(ins.GetInstanceId())
229227
// if err != nil {
230228
// return nil, err
231229
// }
232-
// fmt.Println(ins.GetMonitorQueryKey(), "getUdpSeries耗时", time.Since(start1).Milliseconds(), "series", len(series))
233230
// for _, udpListenersInfo := range udpListenersInfos.Response.ListenerSet {
234231
// for _, realServerSet := range udpListenersInfo.RealServerSet {
235232
// ql := map[string]string{

pkg/collector/product.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,21 +102,18 @@ func (c *TcProductCollector) LoadMetricsByProductConf() error {
102102
series, err := c.handler.GetSeries(nm)
103103
if err != nil {
104104
level.Error(c.logger).Log("msg", "create metric series err", "err", err, "Namespace", c.Namespace, "name", mname)
105-
// continue
106105
}
107106
level.Info(c.logger).Log("msg", "found instances", "count", len(series), "Namespace", c.Namespace, "name", mname, "cost", time.Since(start).Milliseconds())
108107
err = nm.LoadSeries(series)
109108
if err != nil {
110109
level.Error(c.logger).Log("msg", "load metric series err", "err", err, "Namespace", c.Namespace, "name", mname)
111-
// continue
112110
}
113111
group.Done()
114112
}(mname, wg)
115113
}
116114
wg.Wait()
117115
} else {
118116
for _, mname := range metricNames {
119-
start := time.Now()
120117
nm, err := c.createMetricWithProductConf(mname, pconf)
121118
if err != nil {
122119
level.Warn(c.logger).Log("msg", "Create metric fail", "err", err, "Namespace", c.Namespace, "name", mname)
@@ -134,7 +131,7 @@ func (c *TcProductCollector) LoadMetricsByProductConf() error {
134131
level.Error(c.logger).Log("msg", "create metric series err", "err", err, "Namespace", c.Namespace, "name", mname)
135132
continue
136133
}
137-
level.Info(c.logger).Log("msg", "found instances", "count", len(series), "Namespace", c.Namespace, "name", mname, "cost", time.Since(start).Milliseconds())
134+
level.Info(c.logger).Log("msg", "found instances", "count", len(series), "Namespace", c.Namespace, "name", mname, "cost")
138135
err = nm.LoadSeries(series)
139136
if err != nil {
140137
level.Error(c.logger).Log("msg", "load metric series err", "err", err, "Namespace", c.Namespace, "name", mname)
@@ -380,12 +377,10 @@ func NewTcProductCollector(namespace string, metricRepo metric.TcmMetricReposito
380377
if err != nil {
381378
return nil, err
382379
}
383-
start := time.Now()
384380
err = c.LoadMetricsByProductConf()
385381
if err != nil {
386382
return nil, err
387383
}
388-
fmt.Println("耗时", time.Since(start).Milliseconds())
389384
err = c.initQuerys()
390385
if err != nil {
391386
return nil, err

pkg/instance/cache.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -554,8 +554,10 @@ func (c *TcGaapInstanceInfosCache) GetTCPListenersInfo(instanceId string) (*gaap
554554
if err != nil {
555555
return nil, err
556556
}
557+
c.mu.Lock()
557558
c.tcpCache[instanceId] = tcpListeners
558559
c.lastReloadTime[instanceId] = time.Now()
560+
c.mu.Unlock()
559561
level.Debug(c.logger).Log("msg", "Get gaap Namespaces info from api", "instanceId", instanceId)
560562
return tcpListeners, nil
561563
}
@@ -572,8 +574,10 @@ func (c *TcGaapInstanceInfosCache) GetUDPListenersInfo(instanceId string) (*gaap
572574
if err != nil {
573575
return nil, err
574576
}
577+
c.mu.Lock()
575578
c.udpCache[instanceId] = udpListeners
576579
c.lastReloadTime[instanceId] = time.Now()
580+
c.mu.Unlock()
577581
level.Debug(c.logger).Log("msg", "Get gaap Namespaces info from api", "instanceId", instanceId)
578582
return udpListeners, nil
579583
}
@@ -590,8 +594,10 @@ func (c *TcGaapInstanceInfosCache) GetProxyGroupList(instanceId string) (*gaap.D
590594
if err != nil {
591595
return nil, err
592596
}
597+
c.mu.Lock()
593598
c.groupCache[instanceId] = proxyGroupList
594599
c.lastReloadTime[instanceId] = time.Now()
600+
c.mu.Unlock()
595601
level.Debug(c.logger).Log("msg", "Get gaap Namespaces info from api", "instanceId", instanceId)
596602
return proxyGroupList, nil
597603
}
@@ -633,8 +639,10 @@ func (c *TcCommonGaapInstanceInfosCache) GetCommonQaapProxyInstances(instanceId
633639
if err != nil {
634640
return ProxyInstancesRsp{}, err
635641
}
642+
c.mu.Lock()
636643
c.proxyInstancesCache[instanceId] = proxyGroupList
637644
c.lastReloadTime[instanceId] = time.Now()
645+
c.mu.Unlock()
638646
level.Debug(c.logger).Log("msg", "Get gaap Namespaces info from api", "instanceId", instanceId)
639647
return proxyGroupList, nil
640648
}
@@ -651,8 +659,10 @@ func (c *TcCommonGaapInstanceInfosCache) GetCommonQaapNoneBgpIpList(instanceId s
651659
if err != nil {
652660
return NoneBgpIpListRsp{}, err
653661
}
662+
c.mu.Lock()
654663
c.noneBgpIpListCache[instanceId] = proxyGroupList
655664
c.lastReloadTime[instanceId] = time.Now()
665+
c.mu.Unlock()
656666
level.Debug(c.logger).Log("msg", "Get gaap Namespaces info from api", "instanceId", instanceId)
657667
return proxyGroupList, nil
658668
}

0 commit comments

Comments
 (0)