Skip to content

Commit 492368d

Browse files
Minor fix
1 parent d823e41 commit 492368d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/matrixlu.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@ function addpivot!(lu::rrLU{T}, A::AbstractMatrix{T}, newpivot) where {T}
117117
swapcol!(lu, A, k, newpivot[2])
118118

119119
if lu.leftorthogonal
120-
A[k+1:end, k] /= A[k, k]
120+
A[k+1:end, k] ./= A[k, k]
121121
else
122-
A[k, k+1:end] /= A[k, k]
122+
A[k, k+1:end] ./= A[k, k]
123123
end
124124

125125
# perform BLAS subroutine manually: A <- -x * transpose(y) + A
@@ -145,12 +145,12 @@ function _optimizerrlu!(
145145
reltol::Number=1e-14,
146146
abstol::Number=0.0
147147
) where {T}
148-
maxrank = min(maxrank, size(A)...)
148+
maxrank = min(maxrank, size(A, 1), size(A, 2))
149149
maxerror = 0.0
150150
while lu.npivot < maxrank
151151
k = lu.npivot + 1
152152
newpivot = submatrixargmax(abs2, A, k)
153-
lu.error = abs(A[newpivot...])
153+
lu.error = abs(A[newpivot[1], newpivot[2]])
154154
# Add at least 1 pivot to get a well-defined L * U
155155
if (abs(lu.error) < reltol * maxerror || abs(lu.error) < abstol) && lu.npivot > 0
156156
break

0 commit comments

Comments
 (0)