We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent d823e41 commit 492368dCopy full SHA for 492368d
src/matrixlu.jl
@@ -117,9 +117,9 @@ function addpivot!(lu::rrLU{T}, A::AbstractMatrix{T}, newpivot) where {T}
117
swapcol!(lu, A, k, newpivot[2])
118
119
if lu.leftorthogonal
120
- A[k+1:end, k] /= A[k, k]
+ A[k+1:end, k] ./= A[k, k]
121
else
122
- A[k, k+1:end] /= A[k, k]
+ A[k, k+1:end] ./= A[k, k]
123
end
124
125
# perform BLAS subroutine manually: A <- -x * transpose(y) + A
@@ -145,12 +145,12 @@ function _optimizerrlu!(
145
reltol::Number=1e-14,
146
abstol::Number=0.0
147
) where {T}
148
- maxrank = min(maxrank, size(A)...)
+ maxrank = min(maxrank, size(A, 1), size(A, 2))
149
maxerror = 0.0
150
while lu.npivot < maxrank
151
k = lu.npivot + 1
152
newpivot = submatrixargmax(abs2, A, k)
153
- lu.error = abs(A[newpivot...])
+ lu.error = abs(A[newpivot[1], newpivot[2]])
154
# Add at least 1 pivot to get a well-defined L * U
155
if (abs(lu.error) < reltol * maxerror || abs(lu.error) < abstol) && lu.npivot > 0
156
break
0 commit comments