Skip to content

Commit 9351ae3

Browse files
rosboTensorflow Cloud maintainers
authored andcommitted
Increase cloudbuild timeout to 20 minutes.
PiperOrigin-RevId: 344908082
1 parent b739982 commit 9351ae3

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/python/tensorflow_cloud/core/containerize.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ class CloudContainerBuilder(ContainerBuilder):
396396
"""Container builder that uses Google cloud build."""
397397

398398
def get_docker_image(
399-
self, max_status_check_attempts=20, delay_between_status_checks=30
399+
self, max_status_check_attempts=40, delay_between_status_checks=30
400400
):
401401
"""Builds, publishes and returns a Docker image.
402402
@@ -427,7 +427,9 @@ def get_docker_image(
427427
requestBuilder=google_api_client.TFCloudHttpRequest,
428428
)
429429
request_dict = self._create_cloud_build_request_dict(
430-
image_uri, storage_object_name
430+
image_uri,
431+
storage_object_name,
432+
max_status_check_attempts*delay_between_status_checks
431433
)
432434

433435
try:
@@ -494,7 +496,9 @@ def _upload_tar_to_gcs(self):
494496
blob.upload_from_filename(self.tar_file_path)
495497
return storage_object_name
496498

497-
def _create_cloud_build_request_dict(self, image_uri, storage_object_name):
499+
def _create_cloud_build_request_dict(
500+
self, image_uri, storage_object_name, timeout_sec
501+
):
498502
"""Creates request body for cloud build JSON API call.
499503
500504
`create` body should be a `Build` object
@@ -503,6 +507,7 @@ def _create_cloud_build_request_dict(self, image_uri, storage_object_name):
503507
Args:
504508
image_uri: GCR Docker image URI.
505509
storage_object_name: Name of the tarfile object in GCS.
510+
timeout_sec: timeout for the CloudBuild in seconds.
506511
507512
Returns:
508513
Build request dictionary.
@@ -511,6 +516,7 @@ def _create_cloud_build_request_dict(self, image_uri, storage_object_name):
511516
request_dict["projectId"] = self.project_id
512517
request_dict["images"] = [[image_uri]]
513518
request_dict["steps"] = []
519+
request_dict["timeout"] = "{}s".format(timeout_sec)
514520
build_args = ["build", "-t", image_uri, "."]
515521

516522
if self.docker_config:

src/python/tensorflow_cloud/core/tests/unit/containerize_test.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,7 @@ def test_get_docker_image_cloud_build(
444444

445445
request_dict = {}
446446
request_dict["projectId"] = self.project_id
447+
request_dict["timeout"] = "1200s"
447448
request_dict["images"] = [["gcr.io/my-project/tf_cloud_train:abcde"]]
448449
request_dict["steps"] = [{
449450
"name": "gcr.io/cloud-builders/docker",
@@ -612,6 +613,7 @@ def test_get_docker_image_cloud_build_with_custom_image_uri(
612613

613614
request_dict = {}
614615
request_dict["projectId"] = self.project_id
616+
request_dict["timeout"] = "1200s"
615617
request_dict["images"] = [[img_tag]]
616618
request_dict["steps"] = [{
617619
"name": "gcr.io/cloud-builders/docker",
@@ -732,6 +734,7 @@ def test_get_docker_image_cloud_build_with_cache(
732734

733735
request_dict = {}
734736
request_dict["projectId"] = self.project_id
737+
request_dict["timeout"] = "1200s"
735738
request_dict["images"] = [[img_tag]]
736739
request_dict["steps"] = [{
737740
"name": "gcr.io/cloud-builders/docker",

0 commit comments

Comments
 (0)