Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Commit 1f28c31

Browse files
committed
Resolve keras open question and mark RFC as accepted
1 parent ca37121 commit 1f28c31

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

rfcs/20191203-single-eager-graph-path.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Single python code path for eager and graph
22

3-
| Status | Proposed |
3+
| Status | Accepted |
44
:-------------- |:---------------------------------------------------- |
5-
| **RFC #** | 184 |
5+
| **RFC #** | [184](https://github.com/tensorflow/community/pull/184) |
66
| **Author** | Saurabh Saxena ([email protected]) |
77
| **Sponsors** | Alex Passos, Gaurav Jain |
88
| **Updated** | 2019-12-03 |
@@ -317,7 +317,8 @@ Automatic control dependencies (ACD) will move to C++ as well. However instead o
317317

318318
### Open questions
319319

320-
1. Keras seems to be using [non-public APIs](https://github.com/tensorflow/tensorflow/blob/6d7926bb87c1a91ffd110aa3407c003b2ae54009/tensorflow/python/keras/engine/base_layer.py#L2511) for directly building NodeDef and adding that to the graph. This is necessary for supporting Keras's Functional API (Model.add_loss, Model.add_metric, and auto-Lambda layers). We need to figure out if/how to support that. There are ongoing efforts to use just the public API of TF in tf.keras but the timelines for that are unclear.
320+
1. Keras seems to be using [non-public APIs](https://github.com/tensorflow/tensorflow/blob/6d7926bb87c1a91ffd110aa3407c003b2ae54009/tensorflow/python/keras/engine/base_layer.py#L2511) for directly building NodeDef and adding that to the graph. This is necessary for supporting Keras's Functional API (Model.add_loss, Model.add_metric, and auto-Lambda layers). We need to figure out if/how to support that. There are ongoing efforts to use just the public API of TF in tf.keras but the timelines for that are unclear.
321+
1. In the design review it was concluded that we should either be able to change Keras to use public python APIs or replace the internal python API calls with C API calls.
321322

322323

323324
## Appendix

0 commit comments

Comments
 (0)