Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Commit 30b69f1

Browse files
committed
small updates
1 parent 01db945 commit 30b69f1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

rfcs/20201121-keras-model-fit-ps.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,8 @@ class DataFactoryAdapter(DataAdapter):
381381
return False
382382
```
383383

384+
In addition, this `DataAdapter` needs to verify that the `dataset` passed in is infinite.
385+
384386
#### Multiple steps within a train function
385387

386388
Keras training API has a mechanism to run multiple steps within one `tf.function`’ed train function, which is intended for less time spent on RPCs between the coordinator and the workers, and thus better training performance. This is specified as the `steps_per_execution` argument in the `model.compile` call. Parameter server training can naturally benefit from this mechanism, without the need of code changes, but it is worth noting that all steps run within a `tf.function` will be executed on the same worker. The major implication of this is possible limitations on callbacks, as explained in the “Callbacks” section below.

0 commit comments

Comments
 (0)