@@ -35,9 +35,9 @@ enum BuiltinOperator : byte {
3535}
3636```
3737
38- TensorFlow Lite keeps extending more domains in ML and and users require more
39- builtin operators to increase ML model coverage on device, for example, Hash
40- table support and so on.
38+ TensorFlow Lite keeps extending to support more domains in ML and users require
39+ more builtin operators to increase ML model coverage on device, for example,
40+ Hash table support and so on.
4141
4242### Compatibility issues
4343
4848
4949The compatibility issue of newly generated models, that will contain new builtin
5050operators after this proposal's change, from old TensorFlow Lite libraries won't
51- be issues because the TensorFlow Lite library's version always should be the
51+ be a problem because the TensorFlow Lite library's version always should be the
5252same or the newer than the TensorFlow Lite Converter API's version for builtin
5353operator availability.
5454
@@ -84,7 +84,7 @@ table OperatorCode {
8484 // This field is introduced for resolving op builtin operator code shortage problem
8585 // (the original BuiltinOperator enum field was represented as a byte).
8686 // This field will be used when the value of the extended builtin_code field
87- // has greater than BulitinOperator_PLACEHOLDER_FOR_GREATER_OP_CODES .
87+ // has greater than BuiltinOperator_PLACEHOLDER_FOR_GREATER_OP_CODES .
8888 builtin_code:BuiltinOperator;
8989}
9090
@@ -97,9 +97,8 @@ version 3 models will have the default value in the new field. Always the
9797maximum value of the two fields always will be the correct value.
9898
9999```
100- BuiltinOperator builtin_code = builtin_code = std::max(
101- op_code->builtin_code,
102- static_cast<BuiltinOperator>(op_code->deprecated_builtin_code));
100+ BuiltinOperator builtin_code = (op_code->builtin_code ? op_code->builtin_code
101+ : static_cast<BuiltinOperator>(op_code->deprecated_builtin_code));
103102```
104103
105104#### Handling compatibility issues
@@ -118,10 +117,10 @@ The TensorFlow Lite library built after the proposal will read the existing
118117
119118The new ` builtin_code ` field is not available in the version 3 models. Flatbuffer
120119library will feed zero value, which is the default value in the version 3a schema. The
121- actual builtin operatore code value will exist in the deprecated, renamed
120+ actual builtin operator code value will exist in the deprecated, renamed
122121` deprecated_builtin_code ` field. At the same time, it implies that
123122` deprecated_builtin_code ` >= ` builtin_code ` and the maximum value of the two
124- fields will be same with `deprecated_builtin_code'.
123+ fields will be same as `deprecated_builtin_code'.
125124
126125##### Compatibility with old TensorFlow Lite libraries
127126
@@ -143,9 +142,9 @@ option.
143142
144143After the proposal is landed, the codes, that read builtin operator code from
145144TensorFlow Lite Flatbuffer, requires accessing both ` builtin_code ` and
146- ` USE_DEPRECATED_BUILTIN_CODE ` fields.
145+ ` deprecated_builtin_code ` fields.
147146
148- To avoid reduandant logics in a lot of places, the RFC proposes the following
147+ To avoid redundant logics in a lot of places, the RFC proposes the following
149148helper functions in the new C++ library, ` tensorflow/lite/schema:schema_utils ` .
150149
151150```
0 commit comments