Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Commit 4d8e61e

Browse files
committed
Address comments.
1 parent 378feee commit 4d8e61e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rfcs/20191212-keras-categorical-inputs.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Keras categorical inputs
22

3-
| Status | Completed |
3+
| Status | Implemented (https://github.com/tensorflow/community/pull/209) |
44
:-------------- |:---------------------------------------------------- |
55
| **Author(s)** | Zhenyu Tan ([email protected]), Francois Chollet ([email protected])|
66
| **Sponsor** | Karmel Allison ([email protected]), Martin Wicke ([email protected]) |
@@ -23,7 +23,7 @@ Specifically, by introducing the 5 layers, we aim to address these pain points:
2323
* Users have to define both feature columns and Keras Inputs for the model, resulting in code duplication and deviation from DRY (Do not repeat yourself) principle. See this [Github issue](https://github.com/tensorflow/tensorflow/issues/27416).
2424
* Users with large dimension categorical inputs will incur large memory footprint and computation cost, if wrapped with indicator column through `tf.keras.layers.DenseFeatures`.
2525
* Currently there is no way to correctly feed Keras linear model or dense layer with multivalent categorical inputs or weighted categorical inputs, or shared embedding inputs.
26-
* feature columns offer black-box implementations, mix feature engineering with trainable objects, and lead to
26+
* Feature columns offer black-box implementations, mix feature engineering with trainable objects, and lead to
2727
unintended coding pattern.
2828

2929
## User Benefit

0 commit comments

Comments
 (0)