Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Commit 8f1af58

Browse files
committed
* Update transition
1 parent a3b8b6d commit 8f1af58

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

rfcs/20200525-gelu-migration.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ to much for us to continue to support it in Addons.
2828

2929
## Implementation Details
3030
* Link to implementation in Addons:
31-
* Python: [https://github.com/tensorflow/addons/blob/r0.10/tensorflow_addons/activations/gelu.py](https://github.com/tensorflow/addons/blob/r0.10/tensorflow_addons/activations/gelu.py)
32-
* C++ : [https://github.com/tensorflow/addons/blob/r0.10/tensorflow_addons/custom_ops/activations/cc/kernels/gelu_op.h](https://github.com/tensorflow/addons/blob/r0.10/tensorflow_addons/custom_ops/activations/cc/kernels/gelu_op.h)
31+
* Python: https://github.com/tensorflow/addons/blob/r0.10/tensorflow_addons/activations/gelu.py
32+
* C++ : https://github.com/tensorflow/addons/blob/r0.10/tensorflow_addons/custom_ops/activations/cc/kernels/gelu_op.h
3333
* Does this include custom-op kernels?
3434
* Yes, but currently proposing to just migrate the python composite op. This may
3535
change with discussion in the RFC.
@@ -61,13 +61,15 @@ upstream version.
6161
* The activation would land in [nn_ops.py](https://github.com/tensorflow/tensorflow/blob/r2.2/tensorflow//python/ops/nn_ops.py) as well as in [keras advaced_activations](https://github.com/tensorflow/tensorflow/blob/r2.2/tensorflow/python/keras/layers/advanced_activations.py)
6262
* No planned changes to the parameter signatures at this time
6363
* Addons would deprecate our activation and make a call to the core functionality.
64+
* After merging to TF Core:
65+
* Consolidate/remove https://github.com/tensorflow/models/blob/r2.2.0/official/modeling/activations/gelu.py
66+
* Consolidate/remove https://github.com/tensorflow/models/blob/r2.2.0/official/modeling/activations/gelu_test.py
67+
* Consolidate/remove https://github.com/tensorflow/models/blob/r2.2.0/official/nlp/xlnet/xlnet_modeling.py#L29
6468

6569
## Relevant GitHub Issues
66-
https://github.com/tensorflow/tensorflow/pull/33945
67-
68-
https://github.com/tensorflow/addons/issues/550
69-
70-
https://github.com/tensorflow/tensorflow/issues/32783
70+
* https://github.com/tensorflow/tensorflow/pull/33945
71+
* https://github.com/tensorflow/addons/issues/550
72+
* https://github.com/tensorflow/tensorflow/issues/32783
7173

7274
## Questions and Discussion Topics
7375
* Whom from the TF core team would sponsor this migration and ownership of the API?

0 commit comments

Comments
 (0)