Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Commit d33c59e

Browse files
committed
grammar fix
1 parent d46c46e commit d33c59e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rfcs/20200928-sharded-variable.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ From our experiences, parameter servers often become the bottleneck of the train
3636

3737
TF 1.x supports [PartitionedVariable](https://www.tensorflow.org/api_docs/python/tf/compat/v1/get_variable) and this feature is currently missing in TF 2.x. We'd like to add some level of support along with the new `ParameterServerStrategy` proposed in the aforementioned single-client parameter server training [RFC](https://github.com/tensorflow/community/pull/214).
3838

39-
Note that previously a [RFC](https://github.com/tensorflow/community/blob/05e6343409a03d203e676b8c37a89370e6e67dae/rfcs/20190116-embedding-partitioned-variable.md) was published regarding sharded variable for TF 2.x. As things have evolved, especially with the proposal of the new `ParameterServerStrategy`, we feel it is necessary to write a new RFC to accommodate all the moving pieces. The notable differences between this RFC and the old RFC are:
39+
Note that previously an [RFC](https://github.com/tensorflow/community/blob/05e6343409a03d203e676b8c37a89370e6e67dae/rfcs/20190116-embedding-partitioned-variable.md) was published regarding sharded variable for TF 2.x. As things have evolved, especially with the proposal of the new `ParameterServerStrategy`, we feel it is necessary to write a new RFC to accommodate all the moving pieces. The notable differences between this RFC and the old RFC are:
4040

4141
1. **APIs**. This RFC proposes to use variable creator scope (namely, strategy.scope()) to control the creation of sharded variables, while the old RFC proposed to add a method to strategy: `strategy.create_sharded_variable`. We believe that variable creator scope approach is less intrusive to layers.
4242
2. **Layer partition**. The old RPC focused on partitioning embedding layers, while this RPC proposes to support partitioning any type of layers. We have seen performance improvements for certain models when dense layers are partitioned (b/160977486).

0 commit comments

Comments
 (0)