Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Commit f624eb3

Browse files
committed
Update RFC based on review comments
1. Fix typo in Alex's name. 2. Update the API candidates based on comments. 3. Fix format for _ in the tf._internal.
1 parent 6020a36 commit f624eb3

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

rfcs/20200810-tf-internal-api.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
:-------------- |:---------------------------------------------------- |
55
| **RFC #** | [278](https://github.com/tensorflow/community/pull/278)|
66
| **Author(s)** | Qianli Zhu ([email protected]) |
7-
| **Sponsor** | Martin Wicke ([email protected]), Alex Apassos ([email protected])|
7+
| **Sponsor** | Martin Wicke ([email protected]), Alex Passos ([email protected])|
88
| **Updated** | 2020-08-10 |
99
| **Intended audience**| tf-api-owners, tf-addons, keras-team, deepmind/sonnet|
1010

@@ -97,10 +97,9 @@ and will discuss with the API owner on a case to case basis.
9797
|python.framework.func_graph.FuncGraph |tf.internal.FuncGraph |
9898
|python.framework.combinations.*| tf.internal.test.combinations.* |
9999
|python.distribute.strategy_combinations.* |tf.internal.test.combinations.* |
100-
|python.training.tracking.base.no_automatic_dependency_tracking|tf.internal.tracking.no_automatic_dependency_tracking |
101100
|python.util.object_identity.*|tf.internal.object_identity.* |
102-
|python.util.tf_decorator.*|tf.internal.decorator.* |
103-
|python.util.tf_inspect.*|tf.internal.inspect.* |
101+
|python.util.tf_decorator.TFDecorator|tf.internal.decorator.TFDecorator |
102+
|python.util.tf_decorator.unwrap|tf.internal.inspect.unwrap |
104103

105104
### Alternative Names
106105
1. <b>"tf.internal"</b>: It gives the user the impression that this is not a
@@ -109,7 +108,7 @@ and will discuss with the API owner on a case to case basis.
109108
1. <b>"tf.infra"</b>: infrastructure is aligned with "building blocks" and low
110109
level functionalities, like file system/network etc. So far, the APIs we want
111110
to add are still high level APIs and utility functions.
112-
1. By Martin <b>"tf._internal"</b>: the extra "_" emphasis in the pythonic way
111+
1. By Martin <b>"tf.\_internal"</b>: the extra "_" emphasis in the pythonic way
113112
that this is for private usage.
114113

115114

0 commit comments

Comments
 (0)