no-op

PiperOrigin-RevId: 325308481

Author: tfx-copybara

tensorflow_data_validation/statistics/generators/top_k_uniques_sketch_stats_generator.py

@@ -179,16 +179,16 @@ def merge_accumulators(
       self,
       accumulators: Iterable[Dict[tfdv_types.FeaturePath, _CombinedSketch]]
       ) -> Dict[tfdv_types.FeaturePath, _CombinedSketch]:
-    new_acc = {}
-    for acc in accumulators:
-      for feature_name, combined_sketch in acc.items():
-        existing_sketch = new_acc.get(feature_name, None)
+    result = {}
+    for accumulator in accumulators:
+      for feature_name, combined_sketch in accumulator.items():
+        existing_sketch = result.get(feature_name, None)
         if existing_sketch is None:
-          new_acc[feature_name] = combined_sketch
+          result[feature_name] = combined_sketch
         else:
           existing_sketch.merge(combined_sketch)
-          new_acc[feature_name] = existing_sketch
-    return new_acc
+          result[feature_name] = existing_sketch
+    return result
 
   def extract_output(
       self, accumulator: Dict[tfdv_types.FeaturePath, _CombinedSketch]

tensorflow_data_validation/statistics/generators/top_k_uniques_sketch_stats_generator_test.py

@@ -93,10 +93,8 @@ def test_topk_uniques_sketch_with_single_bytes_feature(self):
           }
       }""", statistics_pb2.FeatureNameStatistics())
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        num_top_values=4, num_rank_histogram_buckets=3)
 
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
@@ -201,10 +199,8 @@ def test_topk_uniques_sketch_with_weights(self):
                   }
               }""", statistics_pb2.FeatureNameStatistics())
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            weight_feature='w', num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        weight_feature='w', num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_uniques_sketch_with_single_unicode_feature(self):
@@ -264,10 +260,8 @@ def test_topk_uniques_sketch_with_single_unicode_feature(self):
                   }
               }""", statistics_pb2.FeatureNameStatistics())
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_uniques_sketch_with_multiple_features(self):
@@ -373,10 +367,8 @@ def test_topk_uniques_sketch_with_multiple_features(self):
                   }
               }""", statistics_pb2.FeatureNameStatistics())
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_uniques_sketch_zero_row(self):
@@ -385,19 +377,15 @@ def test_topk_uniques_sketch_zero_row(self):
                                    ['f1'])
     ]
     expected_result = {}
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_uniques_sketch_empty_record_batch(self):
     batches = [pa.RecordBatch.from_arrays([], [])]
     expected_result = {}
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_uniques_sketch_with_missing_feature(self):
@@ -502,10 +490,8 @@ def test_topk_uniques_sketch_with_missing_feature(self):
                   }
               }""", statistics_pb2.FeatureNameStatistics())
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_uniques_sketch_with_numeric_feature(self):
@@ -568,10 +554,8 @@ def test_topk_uniques_sketch_with_numeric_feature(self):
                   }
               }""", statistics_pb2.FeatureNameStatistics())
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_uniques_sketch_with_categorical_feature(self):
@@ -639,10 +623,8 @@ def test_topk_uniques_sketch_with_categorical_feature(self):
           }
         }
         """, schema_pb2.Schema())
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            schema=schema, num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        schema=schema, num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_with_frequency_threshold(self):
@@ -723,12 +705,10 @@ def test_topk_with_frequency_threshold(self):
         }""", statistics_pb2.FeatureNameStatistics())
     }
 
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            weight_feature='w',
-            num_top_values=5, frequency_threshold=2,
-            weighted_frequency_threshold=15, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        weight_feature='w',
+        num_top_values=5, frequency_threshold=2,
+        weighted_frequency_threshold=15, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
   def test_topk_struct_leaves(self):
@@ -916,13 +896,11 @@ def test_topk_struct_leaves(self):
                 step: "f2"
               }""", statistics_pb2.FeatureNameStatistics()),
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            schema=schema,
-            weight_feature='w',
-            num_top_values=3,
-            num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        schema=schema,
+        weight_feature='w',
+        num_top_values=3,
+        num_rank_histogram_buckets=3)
 
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
@@ -1028,10 +1006,8 @@ def test_topk_uniques_sketch_with_int_weights(self):
                   }
               }""", statistics_pb2.FeatureNameStatistics())
     }
-    generator = (
-        sketch_generator
-        .TopKUniquesSketchStatsGenerator(
-            weight_feature='w', num_top_values=4, num_rank_histogram_buckets=3))
+    generator = sketch_generator.TopKUniquesSketchStatsGenerator(
+        weight_feature='w', num_top_values=4, num_rank_histogram_buckets=3)
     self.assertCombinerOutputEqual(batches, generator, expected_result)
 
 if __name__ == '__main__':