Use the file suffix instead file format enum value

tomvdw · The TensorFlow Datasets Authors · commit 099144b518f3 · 2024-09-04T07:01:45.000-07:00
PiperOrigin-RevId: 670954878
diff --git a/tensorflow_datasets/scripts/cli/convert_format_utils.py b/tensorflow_datasets/scripts/cli/convert_format_utils.py
@@ -86,7 +86,7 @@ def _shard_instructions_for_split(
 
   in_filename_template = split_info.filename_template
   out_filename_template = in_filename_template.replace(
-      data_dir=out_path, filetype_suffix=out_file_format.value
+      data_dir=out_path, filetype_suffix=out_file_format.file_suffix
   )
   num_shards = len(split_info.shard_lengths)
   if num_shards <= 0:
diff --git a/tensorflow_datasets/scripts/cli/convert_format_utils_test.py b/tensorflow_datasets/scripts/cli/convert_format_utils_test.py
@@ -66,6 +66,8 @@ def test_shard_instructions_for_split():
   ]
 
 
+
+
 def test_create_out_dir():
   actual = convert_format_utils._create_out_dir(
       dataset_dir='/a/b/c/d',

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ def _shard_instructions_for_split(`
`86`	`86`
`87`	`87`	`in_filename_template = split_info.filename_template`
`88`	`88`	`out_filename_template = in_filename_template.replace(`
`89`		`- data_dir=out_path, filetype_suffix=out_file_format.value`
	`89`	`+ data_dir=out_path, filetype_suffix=out_file_format.file_suffix`
`90`	`90`	`)`
`91`	`91`	`num_shards = len(split_info.shard_lengths)`
`92`	`92`	`if num_shards <= 0:`
Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,8 @@ def test_shard_instructions_for_split():`
`66`	`66`	`]`
`67`	`67`
`68`	`68`
	`69`	`+`
	`70`	`+`
`69`	`71`	`def test_create_out_dir():`
`70`	`72`	`actual = convert_format_utils._create_out_dir(`
`71`	`73`	`dataset_dir='/a/b/c/d',`