Skip to content

Commit 45e71b3

Browse files
fineguyThe TensorFlow Datasets Authors
authored andcommitted
Support uppercase letters in dataset names for tfds new command.
PiperOrigin-RevId: 625651121
1 parent 3a34edd commit 45e71b3

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

tensorflow_datasets/scripts/cli/cli_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def __post_init__(self):
5353
if self.in_tfds
5454
else 'tensorflow_datasets'
5555
)
56-
self.todo = f'TODO({self.name})'
56+
self.todo = f'TODO({self.name.lower()})'
5757

5858
if self.in_tfds:
5959
# `/path/to/tensorflow_datasets/image/my_dataset`

tensorflow_datasets/scripts/cli/new.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def create_dataset_files(
8787
) -> None:
8888
"""Creates the dataset files."""
8989
# Creates the root directory
90-
dataset_dir = dataset_dir.expanduser().resolve() / dataset_name
90+
dataset_dir = dataset_dir.expanduser().resolve() / dataset_name.lower()
9191
dataset_dir.mkdir(parents=True)
9292
in_tfds = 'tensorflow_datasets' in dataset_dir.parts
9393

@@ -118,28 +118,34 @@ def create_dataset_files(
118118
)
119119

120120

121+
def _get_filename(info: utils.DatasetInfo) -> str:
122+
"""Returns the dataset builder filename without Py extension."""
123+
return f'{info.name.lower()}_dataset_builder'
124+
125+
121126
def _create_dataset_file(info: utils.DatasetInfo) -> None:
122127
"""Create a new dataset from a template."""
123-
file_path = info.path / f'{info.name}_dataset_builder.py'
128+
file_path = info.path / (_get_filename(info) + '.py')
124129

125130
content = builder_templates.create_builder_template(info)
126131
file_path.write_text(content)
127132

128133

129134
def _create_dataset_test(info: utils.DatasetInfo) -> None:
130135
"""Adds the `dummy_data/` directory."""
131-
file_path = info.path.joinpath(f'{info.name}_dataset_builder_test.py')
136+
filename = _get_filename(info)
137+
file_path = info.path / (filename + '_test.py')
132138

133139
content = textwrap.dedent(f'''\
134140
"""{info.name} dataset."""
135141
136-
from {info.ds_import} import {info.name}_dataset_builder
142+
from {info.ds_import} import {filename}
137143
import {info.tfds_api} as tfds
138144
139145
class {info.cls_name}Test(tfds.testing.DatasetBuilderTestCase):
140146
"""Tests for {info.name} dataset."""
141147
# {info.todo}:
142-
DATASET_CLASS = {info.name}_dataset_builder.Builder
148+
DATASET_CLASS = {filename}.Builder
143149
SPLITS = {{
144150
'train': 3, # Number of fake train example
145151
'test': 1, # Number of fake test example

0 commit comments

Comments
 (0)