do not remove data_dir builder_kwarg

tomvdw · The TensorFlow Datasets Authors · commit 54dcd163609d · 2024-10-31T09:01:07.000-07:00
PiperOrigin-RevId: 691821364
diff --git a/tensorflow_datasets/core/load.py b/tensorflow_datasets/core/load.py
@@ -170,9 +170,6 @@ def builder(
   name, builder_kwargs = naming.parse_builder_name_kwargs(
       name, **builder_kwargs
   )
-  # Make sure that `data_dir` is not set to an empty string or None.
-  if 'data_dir' in builder_kwargs and not builder_kwargs['data_dir']:
-    builder_kwargs.pop('data_dir')
 
   def get_dataset_repr() -> str:
     return f'dataset "{name}", builder_kwargs "{builder_kwargs}"'

Original file line number	Diff line number	Diff line change
`@@ -170,9 +170,6 @@ def builder(`
`170`	`170`	`name, builder_kwargs = naming.parse_builder_name_kwargs(`
`171`	`171`	`name, **builder_kwargs`
`172`	`172`	`)`
`173`		- # Make sure that `data_dir` is not set to an empty string or None.
`174`		`- if 'data_dir' in builder_kwargs and not builder_kwargs['data_dir']:`
`175`		`- builder_kwargs.pop('data_dir')`
`176`	`173`
`177`	`174`	`def get_dataset_repr() -> str:`
`178`	`175`	`return f'dataset "{name}", builder_kwargs "{builder_kwargs}"'`