Skip to content

Commit 7e52fe4

Browse files
tomvdwThe TensorFlow Datasets Authors
authored andcommitted
Fix bug in convert_format_utils that didn't correctly handle an empty out_dir
PiperOrigin-RevId: 686608981
1 parent baaa7af commit 7e52fe4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tensorflow_datasets/scripts/cli/convert_format.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def _parse_dataset_version_dir(
123123

124124
parser.set_defaults(
125125
subparser_fn=lambda args: convert_format_utils.convert_dataset(
126-
out_dir=args.out_dir if args.out_dir else None,
126+
out_dir=epath.Path(args.out_dir) if args.out_dir else None,
127127
out_file_format=args.out_file_format,
128128
dataset_dir=args.dataset_dir or None,
129129
root_data_dir=args.root_data_dir or None,

tensorflow_datasets/scripts/cli/convert_format_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ def _create_from_to_dirs(
428428
from_to_dirs: dict[epath.Path, epath.Path] = {}
429429
for reference in references:
430430
dataset_dir = reference.dataset_dir()
431-
if out_path is None:
431+
if not out_path:
432432
out_dir = dataset_dir
433433
else:
434434
out_dir = _create_out_dir(

0 commit comments

Comments
 (0)