@@ -260,7 +260,7 @@ def _split_generators(
260
260
split ['name' ]: self ._generate_examples (
261
261
filters = {
262
262
** self ._filters ,
263
- split_reference .reference_field .id : split ['name' ]. encode () ,
263
+ split_reference .reference_field .id : split ['name' ],
264
264
}
265
265
)
266
266
for split in split_reference .split_record_set .data
@@ -285,15 +285,10 @@ def _generate_examples(
285
285
record_set = croissant_utils .get_record_set (
286
286
self .builder_config .name , metadata = self .metadata
287
287
)
288
- records = self .dataset .records (record_set .id )
288
+ records = self .dataset .records (record_set .id , filters = filters )
289
289
for i , record in enumerate (records ):
290
290
# Some samples might not be TFDS-compatible as-is, e.g. from croissant
291
291
# describing HuggingFace datasets, so we convert them here. This shouldn't
292
292
# impact datasets which are already TFDS-compatible.
293
293
record = conversion_utils .to_tfds_value (record , self .info .features )
294
- # After partition implementation, the filters will be applied from
295
- # mlcroissant `dataset.records` directly.
296
- # `records = records.filter(f == v for f, v in filters.items())``
297
- # For now, we apply them in TFDS.
298
- if all (record [filter ] == value for filter , value in filters .items ()):
299
- yield i , record
294
+ yield i , record
0 commit comments