Fix broken caching for custom page_info classes.

This is why the raw_ops page is broken:

https://www.tensorflow.org/api_docs/python/tf/raw_ops

PiperOrigin-RevId: 437232519

Author: MarkDaoust

tools/tensorflow_docs/api_generator/generate_lib.py

@@ -563,7 +563,7 @@ def write_docs(
 
     try:
       path.parent.mkdir(exist_ok=True, parents=True)
-      path.write_text(page_info.text, encoding='utf-8')
+      path.write_text(page_info.page_text, encoding='utf-8')
       num_docs_output += 1
     except OSError as e:
       raise OSError('Cannot write documentation for '

tools/tensorflow_docs/api_generator/pretty_docs/base_page.py

@@ -14,8 +14,9 @@
 # ==============================================================================
 """Base classes for page construction."""
 import abc
-import functools
+import os
 import pathlib
+import posixpath
 import textwrap
 from typing import Any, ClassVar, Dict, List, NamedTuple, Optional, Sequence, Tuple, Type
 
@@ -103,6 +104,7 @@ class PageInfo:
     search_hints: If true include metadata search hints, else include a
       "robots: noindex"
     text: The resulting page text.
+    page_text: The cached result.
   """
   DEFAULT_BUILDER_CLASS: ClassVar[Type[PageBuilder]] = TemplatePageBuilder
 
@@ -122,6 +124,7 @@ def __init__(
         that need to be added to the markdown pages created.
       search_hints: If true include metadata search hints, else include a
         "robots: noindex"
+
     """
     self.full_name = full_name
     self.py_object = py_object
@@ -131,22 +134,53 @@ def __init__(
     self._defined_in = None
     self._aliases = None
     self._doc = None
-    self._text = None
+    self._page_text = None
 
   def collect_docs(self, parser_config: config.ParserConfig):
     """Collects additional information from the `config.ParserConfig`."""
     pass
 
+  def docs_for_object(self, parser_config):
+    duplicate_names = parser_config.duplicates.get(self.full_name, [])
+    if self.full_name in duplicate_names:
+      duplicate_names.remove(self.full_name)
+
+    relative_path = os.path.relpath(
+        path='.',
+        start=os.path.dirname(parser.documentation_path(self.full_name)) or '.')
+
+    # Convert from OS-specific path to URL/POSIX path.
+    relative_path = posixpath.join(*relative_path.split(os.path.sep))
+
+    with parser_config.reference_resolver.temp_prefix(relative_path):
+      self.set_doc(
+          parser.parse_md_docstring(
+              self.py_object,
+              self.full_name,
+              parser_config,
+              self._extra_docs,
+          ))
+
+      self.collect_docs(parser_config)
+
+      self.set_aliases(duplicate_names)
+
+      self.set_defined_in(parser.get_defined_in(self.py_object, parser_config))
+
+      self._page_text = self.build()
+
+    return self._page_text
+
   def build(self) -> str:
     """Builds the documentation."""
     cls = self.DEFAULT_BUILDER_CLASS
-    text = cls(self).build()
-    self._text = text
-    return text
+    return cls(self).build()
 
   @property
-  def text(self):
-    return self._text
+  def page_text(self):
+    if self._page_text is None:
+      self._page_text = self.build()
+    return self._page_text
 
   def __eq__(self, other):
     if isinstance(other, PageInfo):
@@ -198,7 +232,6 @@ def set_doc(self, doc: parser.DocstringInfo):
     self._doc = doc
 
 
-
 class MemberInfo(NamedTuple):
   """Describes an attribute of a class or module."""
   short_name: str

tools/tensorflow_docs/api_generator/pretty_docs/docs_for_object.py

@@ -13,15 +13,11 @@
 # limitations under the License.
 # ==============================================================================
 """Create a `pretty_docs.base_page.PageInfo` from a python object."""
-import os
-import posixpath
-
 from typing import Any, Dict, Optional, Type
 
 from tensorflow_docs.api_generator import config
 from tensorflow_docs.api_generator import doc_controls
 from tensorflow_docs.api_generator import obj_type as obj_type_lib
-from tensorflow_docs.api_generator import parser
 from tensorflow_docs.api_generator.pretty_docs import base_page
 from tensorflow_docs.api_generator.pretty_docs import class_page
 from tensorflow_docs.api_generator.pretty_docs import function_page
@@ -75,9 +71,6 @@ def docs_for_object(
 
   # Which other aliases exist for the object referenced by full_name?
   main_name = parser_config.reference_resolver.py_main_name(full_name)
-  duplicate_names = parser_config.duplicates.get(main_name, [])
-  if main_name in duplicate_names:
-    duplicate_names.remove(main_name)
 
   if page_builder_classes is None:
     page_builder_classes = _DEFAULT_PAGE_BUILDER_CLASSES
@@ -93,28 +86,6 @@ def docs_for_object(
       search_hints=search_hints,
       extra_docs=extra_docs)
 
-  relative_path = os.path.relpath(
-      path='.',
-      start=os.path.dirname(parser.documentation_path(full_name)) or '.')
-
-  # Convert from OS-specific path to URL/POSIX path.
-  relative_path = posixpath.join(*relative_path.split(os.path.sep))
-
-  with parser_config.reference_resolver.temp_prefix(relative_path):
-    page_info.set_doc(
-        parser.parse_md_docstring(
-            py_object,
-            full_name,
-            parser_config,
-            extra_docs,
-        ))
-
-    page_info.collect_docs(parser_config)
-
-    page_info.set_aliases(duplicate_names)
-
-    page_info.set_defined_in(parser.get_defined_in(py_object, parser_config))
-
-    page_info.build()
+  page_info.docs_for_object(parser_config)
 
   return page_info