Skip to content

Commit 7257bbb

Browse files
fredrectensorflower-gardener
authored andcommitted
Assign bug numbers to TODOs
PiperOrigin-RevId: 369773833
1 parent fb8ed37 commit 7257bbb

File tree

8 files changed

+9
-9
lines changed

8 files changed

+9
-9
lines changed

ci/kokoro/gcp_ubuntu/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# An image for building prerequisites for testing TensorFlow Model Optimization
1616
# on ubuntu.
1717
#
18-
# TODO(tfmot): generalize to different versions of TensorFlow to
18+
# TODO(b/185727356): generalize to different versions of TensorFlow to
1919
# run CI against.
2020
#
2121
# Build as follows:

ci/kokoro/gcp_ubuntu/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# be used to reproduce errors locally by modifying WORKDIR to be
1919
# the top-level directory of the checked out TFMOT Github repository.
2020

21-
# TODO(tfmot): switch to prebuilt Docker image to speed this up.
21+
# TODO(b/185727163): switch to prebuilt Docker image to speed this up.
2222

2323
# Fail on any error.
2424
set -e

tensorflow_model_optimization/python/core/common/keras/compression/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ py_library(
77
visibility = ["//visibility:public"],
88
deps = [
99
"//tensorflow_model_optimization/python/core/common/keras/compression/internal:optimize",
10-
#TODO(tfmot): remove when we stick to Python 3.7, which includes this by default.
10+
#TODO(b/185726660): remove when we stick to Python 3.7, which includes this by default.
1111
# dataclasses dep1,
1212
# tensorflow dep1,
1313
],

tensorflow_model_optimization/python/core/common/keras/compression/internal/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ py_library(
99
srcs = ["optimize.py"],
1010
srcs_version = "PY3",
1111
deps = [
12-
#TODO(tfmot): remove when we stick to Python 3.7, which includes this by default.
12+
#TODO(b/185726660): remove when we stick to Python 3.7, which includes this by default.
1313
# dataclasses dep1,
1414
# tensorflow dep1,
1515
],

tensorflow_model_optimization/python/core/quantization/keras/default_8bit/default_8bit_transforms_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ def testAddReLUQuantize(self, activation_type, transform_type):
379379
('relu', default_8bit_transforms.LayerReLUQuantize),
380380
('act_relu', default_8bit_transforms.LayerReluActivationQuantize))
381381
def testLayerReLUQuantize(self, activation_type, transform_type):
382-
# TODO(tfmot): Add tests for DepthConv and Dense
382+
# TODO(b/185727342): Add tests for DepthConv and Dense
383383
input_shape = (1, 3, 3, 3)
384384
conv_layer = tf.keras.layers.Conv2D(5, 2, input_shape=input_shape)
385385
if activation_type == 'relu':

tensorflow_model_optimization/python/core/quantization/keras/quantize_wrapper_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def testQuantizesWeightsInLayer(self):
6868
# 1. Only layers with 'kernel' attribute work. Need to extend to others.
6969
# 2. Activations are not tested currently.
7070
# 3. RNN layers need to be added
71-
# TODO(tfmot): reenable some of these once added back to allowlist
71+
# TODO(b/185968347): reenable some of these once added back to allowlist
7272
# after testing in quantize_functional_test.py.
7373
@parameterized.parameters(
7474
# (layers.Conv1D, (3, 6), {

tensorflow_model_optimization/python/core/sparsity/keras/prune_integration_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def setUp(self):
121121
}
122122

123123
# TODO(pulkitb): Also assert correct weights are pruned.
124-
# TODO(tfmot): this should not be verified in all the unit tests.
124+
# TODO(b/185968817): this should not be verified in all the unit tests.
125125
# As long as there are a few unit tests for strip_pruning,
126126
# these checks are redundant.
127127
def _check_strip_pruning_matches_original(

tensorflow_model_optimization/python/core/sparsity/keras/prune_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ def testPruneScope_NotNeededForTFCheckpoint(self):
397397
same_architecture_model.load_weights(tf_weights)
398398

399399
def testPruneScope_NotNeededForTF2SavedModel(self):
400-
# TODO(tfmot): replace with shared v1 test_util.
400+
# TODO(b/185726968): replace with shared v1 test_util.
401401
is_v1_apis = hasattr(tf, 'assign')
402402
if is_v1_apis:
403403
return
@@ -413,7 +413,7 @@ def testPruneScope_NotNeededForTF2SavedModel(self):
413413
tf.saved_model.load(saved_model_dir)
414414

415415
def testPruneScope_NeededForTF1SavedModel(self):
416-
# TODO(tfmot): replace with shared v1 test_util.
416+
# TODO(b/185726968): replace with shared v1 test_util.
417417
is_v1_apis = hasattr(tf, 'assign')
418418
if not is_v1_apis:
419419
return

0 commit comments

Comments
 (0)