Skip to content

Commit 82a25a3

Browse files
committed
Update logger value type and test
1. Update logger to convert the value type to float to please JSON. 2. Update logger test to call parent test tearDown.
1 parent ff17f5d commit 82a25a3

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

official/benchmark/logger.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,16 @@ def log_metric(self, name, value, unit=None, global_step=None, extras=None):
6060
os.path.join(self._logging_dir, _METRIC_LOG_FILE_NAME), "a") as f:
6161
metric = {
6262
"name": name,
63-
"value": value,
63+
"value": float(value),
6464
"unit": unit,
6565
"global_step": global_step,
6666
"timestamp": datetime.datetime.now().strftime(
6767
_DATE_TIME_FORMAT_PATTERN),
6868
"extras": extras}
69-
json.dump(metric, f)
70-
f.write("\n")
69+
try:
70+
json.dump(metric, f)
71+
f.write("\n")
72+
except (TypeError, ValueError) as e:
73+
tf.logging.warning("Failed to dump metric to log file: name %s, value %s, error %s",
74+
name, value, e)
7175

official/benchmark/logger_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
class BenchmarkLoggerTest(tf.test.TestCase):
3333

3434
def tearDown(self):
35+
super(BenchmarkLoggerTest, self).tearDown()
3536
tf.gfile.DeleteRecursively(self.get_temp_dir())
3637

3738
def test_create_logging_dir(self):

0 commit comments

Comments
 (0)