Skip to content

Possible unnecessary code in ci.yml #912

@mhucka

Description

@mhucka

The CI workflow file ci.yml contains the following in the build job:

    - name: Install clang-format (Linux)
      if: runner.os == 'Linux'
      run: |
        sudo apt-get update
        sudo apt-get install -y clang-format

    - name: Install clang-format (macOS)
      if: runner.os == 'macOS'
      run: |
        brew install clang-format

However,

  1. The job never runs clang-format – it only installs it
  2. The only other job it runs is bazel test src/..., and I can't find evidence in the WORKSPACE or BUILD files that clang-format is invoked from them

It's possible clang-format is needed in a dependency, but just in case this was a left-over in the CI file from something else, I wanted to flag it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions