Merge pull request #391 from dskkato/remove_binary_files

remove binary files from repository

Author: adamcrume

RELEASING.md

@@ -37,7 +37,7 @@ Note that any crate not mentioned here (e.g. tensorflow-proto-codegen, tensorflo
 1. Bump the version number in `Cargo.toml`
 1. Bump the version number in `README.md`
 1. Run `./test-all`
-1. Double-check that addition.py and test_op are built using the version of TensorFlow being linked against.  (See "Upgrading TensorFlow" section.)
+1. Double-check that addition.py is built using the version of TensorFlow being linked against.  (See "Upgrading TensorFlow" section.)
 1. Run `./run-valgrind`
 1. Commit and push the changes. (Push before publishing to ensure that the changes being published are up to date.)
 1. If the version of tensorflow-sys was bumped, run `cargo publish` for tensorflow-sys. (Publish before tagging in case there are problems publishing and we need to add commits to fix them.)
@@ -64,5 +64,4 @@ Note that any crate not mentioned here (e.g. tensorflow-proto-codegen, tensorflo
    1. Run `pip install --upgrade pip`
    1. Run `pip install --upgrade tensorflow==${TENSORFLOW_VERSION?}`
    1. Run `python examples/addition/addition.py`
-   1. Run `test_resources/library/build-test-op` and move `test_op.so` into `test_resources/library/linux`.
    1. Run `deactivate` to exit the virtualenv

src/lib.rs

@@ -2663,22 +2663,23 @@ mod tests {
         assert!(get_registered_kernels_for_op("Add").unwrap().len() > 0);
     }
 
+    #[cfg(target_os = "linux")]
     #[test]
+    #[ignore]
     fn test_library_load() {
-        // This test is not yet implemented for Windows
-        let check_path = match std::env::consts::OS {
-            "linux" => Some("test_resources/library/linux/test_op.so"),
-            // TODO: The test op needs to be recompiled for macos.
-            // "macos" => Some("test_resources/library/macos/test_op.so"),
-            _ => None,
-        };
-        if let Some(path) = check_path {
-            let lib = Library::load(path).unwrap();
-            let ops: Vec<OpDef> = lib.op_list().clone().into();
-            assert!(ops.len() == 1);
-            let op = &ops[0];
-            assert!(op.name() == "TestOpList");
-        };
+        // This test is implemented for linux only.
+        let lib_path = "test_resources/library/test_op.so";
+        assert!(
+            std::path::Path::new(lib_path).exists(),
+            "`{}` was not found. Build the lib and try again : `{}`",
+            lib_path,
+            "(cd test_resources/library && ./build-test-op)"
+        );
+        let lib = Library::load(lib_path).unwrap();
+        let ops: Vec<OpDef> = lib.op_list().clone().into();
+        assert!(ops.len() == 1);
+        let op = &ops[0];
+        assert!(op.name() == "TestOpList");
     }
 
     #[test]

test-all

@@ -48,6 +48,7 @@ if [[ "${version_tensorflow_sys_crate}" != "${version_tensorflow_sys_readme}" ]]
 fi
 
 run python3 examples/mobilenetv3/create_model.py
+# TODO(#391): Re-enable: (cd test_resources/library && ./build-test-op)
 run cargo fmt --all -- --check
 run cargo test -vv -j 2
 run cargo test -vv -j 2 --features eager

test_resources/library/.gitignore

@@ -0,0 +1 @@
+*.so