Fix clippy lints

Author: adamcrume

Cargo.toml

@@ -37,7 +37,7 @@ rustversion = "1.0.9"
 [dev-dependencies]
 rand = "0.8.5"
 serial_test = "0.9.0"
-tempdir = "0.3"
+tempfile = "3.7.0"
 
 [features]
 default = ["tensorflow-sys"]

src/checkpoint.rs

@@ -1,4 +1,3 @@
-use crate::option_insert_result::OptionInsertWithResult;
 use crate::{ops, Operation, Scope, Session, SessionRunArgs, Status, Tensor, Variable};
 
 #[derive(Debug)]
@@ -92,7 +91,7 @@ impl CheckpointMaker {
             )?;
             let tensors = all_variable_ops
                 .iter()
-                .map(|v| v.output(0).clone())
+                .map(|v| v.output(0))
                 .collect::<Vec<_>>();
 
             let mut g = self.scope.graph_mut();
@@ -355,7 +354,7 @@ mod tests {
             first_scope_data.scope.new_sub_scope("checkpoint"),
             Box::from(first_scope_data.variables.clone()),
         );
-        let temp_dir = tempdir::TempDir::new("test-tensorflow")?;
+        let temp_dir = tempfile::tempdir()?;
         let checkpoint_path = temp_dir.path().join("checkpoint-vars");
         let checkpoint_path_str = checkpoint_path
             .into_os_string()

src/graph.rs

@@ -1340,6 +1340,7 @@ impl Operation {
             return Err(status);
         }
         #[allow(trivial_numeric_casts)]
+        #[allow(clippy::unnecessary_cast)]
         Ok(value as f32)
     }
 
@@ -1367,6 +1368,7 @@ impl Operation {
                 return Err(status);
             }
             #[allow(trivial_numeric_casts)]
+            #[allow(clippy::unnecessary_cast)]
             Ok(values.iter().map(|f| f.assume_init() as f32).collect())
         }
     }

src/lib.rs

@@ -1202,6 +1202,7 @@ where
 {
     // This will panic if `unpacked` is false and `unpacked_data` is already borrowed.
     #[allow(trivial_numeric_casts)]
+    #[allow(clippy::unnecessary_cast)]
     fn unpack(&self) {
         if !self.unpacked.get() {
             let mut data = self.unpacked_data.borrow_mut();

tensorflow-op-codegen/src/bin/eager.rs

@@ -731,7 +731,6 @@ fn main() -> Result<(), Box<dyn Error>> {
     let mut out = BufWriter::new(File::create(output_folder.join("src/eager/op/raw_ops.rs"))?);
     write!(
         &mut out,
-        "{}",
         r#"// DO NOT EDIT. Generated by tensorflow-op-codegen/src/main.rs.
 
 "#

tensorflow-op-codegen/src/main.rs

@@ -798,7 +798,6 @@ fn main() -> Result<(), Box<dyn Error>> {
     let mut out = BufWriter::new(File::create(output_folder.join("src/ops/ops_impl.rs"))?);
     write!(
         &mut out,
-        "{}",
         r#"// DO NOT EDIT. Generated by tensorflow-op-codegen/src/main.rs.
 #![allow(
     non_snake_case,