Skip to content

Commit de3fcd4

Browse files
Automated Code Change
PiperOrigin-RevId: 685173649
1 parent d35f71f commit de3fcd4

File tree

3 files changed

+28
-25
lines changed

3 files changed

+28
-25
lines changed

tensorflow_serving/resources/resource_tracker.cc

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@ limitations under the License.
2828
namespace tensorflow {
2929
namespace serving {
3030

31-
Status ResourceTracker::Create(const ResourceAllocation& total_resources,
32-
std::unique_ptr<ResourceUtil> util,
33-
std::unique_ptr<ResourceTracker>* tracker) {
31+
absl::Status ResourceTracker::Create(
32+
const ResourceAllocation& total_resources,
33+
std::unique_ptr<ResourceUtil> util,
34+
std::unique_ptr<ResourceTracker>* tracker) {
3435
TF_RETURN_IF_ERROR(util->VerifyValidity(total_resources));
3536
const ResourceAllocation normalized_total_resources =
3637
util->Normalize(total_resources);
@@ -40,11 +41,11 @@ Status ResourceTracker::Create(const ResourceAllocation& total_resources,
4041
}
4142
tracker->reset(
4243
new ResourceTracker(normalized_total_resources, std::move(util)));
43-
return Status();
44+
return absl::Status();
4445
}
4546

46-
Status ResourceTracker::ReserveResources(const Loader& servable,
47-
bool* success) {
47+
absl::Status ResourceTracker::ReserveResources(const Loader& servable,
48+
bool* success) {
4849
ResourceAllocation servable_resources;
4950
TF_RETURN_IF_ERROR(servable.EstimateResources(&servable_resources));
5051
TF_RETURN_IF_ERROR(util_->VerifyValidity(servable_resources));
@@ -68,10 +69,10 @@ Status ResourceTracker::ReserveResources(const Loader& servable,
6869
*success = false;
6970
}
7071

71-
return Status();
72+
return absl::Status();
7273
}
7374

74-
Status ResourceTracker::RecomputeUsedResources(
75+
absl::Status ResourceTracker::RecomputeUsedResources(
7576
const std::vector<const Loader*>& servables) {
7677
used_resources_.Clear();
7778
for (const Loader* servable : servables) {
@@ -80,7 +81,7 @@ Status ResourceTracker::RecomputeUsedResources(
8081
TF_RETURN_IF_ERROR(util_->VerifyValidity(servable_resources));
8182
util_->Add(servable_resources, &used_resources_);
8283
}
83-
return Status();
84+
return absl::Status();
8485
}
8586

8687
ResourceTracker::ResourceTracker(const ResourceAllocation& total_resources,

tensorflow_serving/resources/resource_tracker_test.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class ResourceTrackerTest : public ::testing::Test {
9292
" } "
9393
" quantity: 3 "
9494
"} ");
95-
return Status();
95+
return absl::Status();
9696
}));
9797

9898
loader_1_.reset(new NiceMock<test_util::MockLoader>);
@@ -114,7 +114,7 @@ class ResourceTrackerTest : public ::testing::Test {
114114
" } "
115115
" quantity: 7 "
116116
"} ");
117-
return Status();
117+
return absl::Status();
118118
}));
119119

120120
loader_2_.reset(new NiceMock<test_util::MockLoader>);
@@ -128,7 +128,7 @@ class ResourceTrackerTest : public ::testing::Test {
128128
" } "
129129
" quantity: 15 "
130130
"} ");
131-
return Status();
131+
return absl::Status();
132132
}));
133133

134134
loader_3_.reset(new NiceMock<test_util::MockLoader>);
@@ -142,7 +142,7 @@ class ResourceTrackerTest : public ::testing::Test {
142142
" } "
143143
" quantity: 12 "
144144
"} ");
145-
return Status();
145+
return absl::Status();
146146
}));
147147

148148
invalid_resources_loader_.reset(new NiceMock<test_util::MockLoader>);
@@ -157,7 +157,7 @@ class ResourceTrackerTest : public ::testing::Test {
157157
" } "
158158
" quantity: 4 "
159159
"} ");
160-
return Status();
160+
return absl::Status();
161161
}));
162162

163163
// Disallow calls to Load()/Unload().

tensorflow_serving/resources/resource_util.cc

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ ResourceAllocation::Entry* FindOrInsertMutableEntry(
9696
ResourceUtil::ResourceUtil(const Options& options)
9797
: devices_(StripDevicesWithZeroInstances(options.devices)) {}
9898

99-
Status ResourceUtil::VerifyValidity(
99+
absl::Status ResourceUtil::VerifyValidity(
100100
const ResourceAllocation& allocation) const {
101-
const Status result = [this, &allocation]() -> Status {
101+
const absl::Status result = [this, &allocation]() -> absl::Status {
102102
// We use 'validated_entries' to look for duplicates.
103103
ResourceAllocation validated_entries;
104104
for (const auto& entry : allocation.resource_quantities()) {
@@ -115,7 +115,7 @@ Status ResourceUtil::VerifyValidity(
115115

116116
*validated_entries.add_resource_quantities() = entry;
117117
}
118-
return Status();
118+
return absl::Status();
119119
}();
120120
if (!result.ok()) {
121121
LOG(ERROR) << result;
@@ -124,8 +124,9 @@ Status ResourceUtil::VerifyValidity(
124124
return result;
125125
}
126126

127-
Status ResourceUtil::VerifyResourceValidity(const Resource& resource) const {
128-
const Status result = [this, &resource]() -> Status {
127+
absl::Status ResourceUtil::VerifyResourceValidity(
128+
const Resource& resource) const {
129+
const absl::Status result = [this, &resource]() -> absl::Status {
129130
auto it = devices_.find(resource.device());
130131
if (it == devices_.end()) {
131132
return errors::InvalidArgument(
@@ -138,7 +139,7 @@ Status ResourceUtil::VerifyResourceValidity(const Resource& resource) const {
138139
"Invalid resource allocation: Invalid device instance ",
139140
resource.device(), ":", resource.device_instance().value());
140141
}
141-
return Status();
142+
return absl::Status();
142143
}();
143144
if (!result.ok()) {
144145
LOG(ERROR) << result;
@@ -147,7 +148,7 @@ Status ResourceUtil::VerifyResourceValidity(const Resource& resource) const {
147148
return result;
148149
}
149150

150-
Status ResourceUtil::VerifyOverrideDeviceValidity(
151+
absl::Status ResourceUtil::VerifyOverrideDeviceValidity(
151152
const ResourceAllocation& base_allocation,
152153
const ResourceAllocation& override_allocation) const {
153154
absl::flat_hash_set<std::pair<std::string, std::string>>
@@ -166,7 +167,7 @@ Status ResourceUtil::VerifyOverrideDeviceValidity(
166167
entry.resource().DebugString());
167168
}
168169
}
169-
return Status();
170+
return absl::Status();
170171
}
171172

172173
ResourceAllocation ResourceUtil::Normalize(
@@ -323,9 +324,10 @@ bool ResourceUtil::IsBoundNormalized(
323324
return true;
324325
}
325326

326-
Status ResourceUtil::VerifyFunctionInternal(
327-
std::function<Status()> fn, DCHECKFailOption dcheck_fail_option) const {
328-
const Status result = fn();
327+
absl::Status ResourceUtil::VerifyFunctionInternal(
328+
std::function<absl::Status()> fn,
329+
DCHECKFailOption dcheck_fail_option) const {
330+
const absl::Status result = fn();
329331

330332
if (dcheck_fail_option == DCHECKFailOption::kDoDCHECKFail) {
331333
TF_DCHECK_OK(result);

0 commit comments

Comments
 (0)