Skip to content

Commit fabf1fd

Browse files
yimingz-atensorflow-copybara
authored andcommitted
Use a copy of ModelWarmupOptions for model warmup.
PiperOrigin-RevId: 764483955
1 parent f105002 commit fabf1fd

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

tensorflow_serving/servables/tensorflow/saved_model_bundle_source_adapter.cc

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,13 @@ SavedModelBundleSourceAdapter::GetServableCreator(
6262
MaybePublishMLMDStreamz(path, metadata.servable_id.name,
6363
metadata.servable_id.version);
6464
if (bundle_factory->config().enable_model_warmup()) {
65-
bundle_factory->mutable_config()
66-
.mutable_model_warmup_options()
67-
->set_model_name(metadata.servable_id.name);
68-
bundle_factory->mutable_config()
69-
.mutable_model_warmup_options()
70-
->set_model_version(metadata.servable_id.version);
71-
return RunSavedModelWarmup(
72-
bundle_factory->config().model_warmup_options(),
73-
GetRunOptions(bundle_factory->config()), path, bundle->get());
65+
ModelWarmupOptions warmup_options =
66+
bundle_factory->config().model_warmup_options();
67+
warmup_options.set_model_name(metadata.servable_id.name);
68+
warmup_options.set_model_version(metadata.servable_id.version);
69+
return RunSavedModelWarmup(warmup_options,
70+
GetRunOptions(bundle_factory->config()),
71+
path, bundle->get());
7472
}
7573
return absl::OkStatus();
7674
};

tensorflow_serving/servables/tensorflow/tfrt_saved_model_factory.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -317,11 +317,11 @@ absl::Status TfrtSavedModelFactory::CreateTfrtSavedModelWithMetadata(
317317
down_cast<TfrtSavedModelServable*>(servable->get());
318318

319319
if (config().enable_model_warmup()) {
320-
auto* warmup_options = mutable_config().mutable_model_warmup_options();
321-
warmup_options->set_model_name(metadata.servable_id.name);
322-
warmup_options->set_model_version(metadata.servable_id.version);
320+
ModelWarmupOptions warmup_options = config().model_warmup_options();
321+
warmup_options.set_model_name(metadata.servable_id.name);
322+
warmup_options.set_model_version(metadata.servable_id.version);
323323
TF_RETURN_IF_ERROR(RunSavedModelWarmup(
324-
*warmup_options, path, config().lazy_init_threshold(),
324+
warmup_options, path, config().lazy_init_threshold(),
325325
config().skip_warmup_requests_if_initialized(),
326326
&tfrt_servable->saved_model()));
327327
if (config().freeze_after_init()) {

0 commit comments

Comments
 (0)