Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Commit 86b86ca

Browse files
authored
build: build sub-modules with the same build config (#1120)
Ensure that we build swift-numerics and PythonKit as the same build type. This is important since ELFish platforms copy DT_NEEDED entries, resulting in over-linking of swiftOnoneSupport which presents issues for release/debug build configuration mismatches.
1 parent b3e326c commit 86b86ca

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ if(ENABLE_SWIFT_NUMERICS)
6666
CMAKE_ARGS
6767
-D BUILD_SHARED_LIBS=YES
6868
-D BUILD_TESTING=NO
69+
-D CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
6970
-D CMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
7071
-D CMAKE_Swift_COMPILER=${CMAKE_Swift_COMPILER}
7172
-D CMAKE_Swift_COMPILER_TARGET=${CMAKE_Swift_COMPILER_TARGET}
@@ -95,6 +96,7 @@ if(ENABLE_PYTHON_SUPPORT)
9596
master
9697
CMAKE_ARGS
9798
-D BUILD_SHARED_LIBS=YES
99+
-D CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
98100
-D CMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
99101
-D CMAKE_Swift_COMPILER=${CMAKE_Swift_COMPILER}
100102
-D CMAKE_Swift_COMPILER_TARGET=${CMAKE_Swift_COMPILER_TARGET}

0 commit comments

Comments
 (0)