Skip to content

Commit 00eeb7a

Browse files
Typo fix in some comments and test descriptions: 'overriden' -> 'overridden' (#6413)
minor typo fix ## Motivation for features / changes ## Technical description of changes ## Screenshots of UI changes (or N/A) ## Detailed steps to verify changes work correctly (as executed by you) ## Alternate designs / implementations considered (or N/A)
1 parent 1650cf6 commit 00eeb7a

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

tensorboard/webapp/feature_flag/effects/feature_flag_effects.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ export class FeatureFlagEffects {
9090
);
9191

9292
/**
93-
* When a feature flag is overriden this effect persists that override by
93+
* When a feature flag is overridden this effect persists that override by
9494
* putting it in local storage using the dataSource.
9595
*/
9696
readonly storeFeatureFlag$ = createEffect(

tensorboard/webapp/feature_flag/store/feature_flag_selectors_test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ describe('feature_flag_selectors', () => {
120120
});
121121

122122
describe('#getFeatureFlagsToSendToServer', () => {
123-
it('returns overriden flags to send to server', () => {
123+
it('returns overridden flags to send to server', () => {
124124
// Give explicit defaultValues and modify sendToServer value for some of
125125
// the properties.
126126
const metadata = {
@@ -165,7 +165,7 @@ describe('feature_flag_selectors', () => {
165165
expect(actual).toEqual({inColab: true});
166166
});
167167

168-
it('ignores overriden flags that should not be sent to server', () => {
168+
it('ignores overridden flags that should not be sent to server', () => {
169169
// Give explicit defaultValues and modify sendToServer value for some of
170170
// the properties.
171171
const metadata = {

tensorboard/webapp/routes/feature_flag_serializer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export function featureFlagsToSerializableQueryParams<T>(
2626
return Object.entries(overriddenFeatureFlags)
2727
.map(([featureFlag, featureValue]) => {
2828
if (featureValue === undefined) {
29-
// Feature flag has no overriden value specified.
29+
// Feature flag has no overridden value specified.
3030
// Return empty item. Will be filtered out.
3131
return {};
3232
}

tensorboard/webapp/webapp_data_source/tb_feature_flag_data_source_types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export abstract class TBFeatureFlagDataSource {
4343

4444
/**
4545
* Removes the localStorage override of the given flag. If the flag is not
46-
* overriden no changes should occur.
46+
* overridden no changes should occur.
4747
*
4848
* @param featureFlag The featureFlag to be reset. It must be a key in the
4949
* FeatureFlags object.

0 commit comments

Comments
 (0)