Skip to content

Commit 12e6bc3

Browse files
authored
Clean Up: Fix sync breakage due to import inconsistencies (#6424)
## Technical Description of Changes It seems like the linter is no longer catching unused variables so that part was easy. There was also an issue with the a missing build rule remapping ~Sync should pass after cl/538963303 is submitted. See example sync cl/538963353~ It really did pass cl/539096814
1 parent 1cddf07 commit 12e6bc3

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

tensorboard/webapp/widgets/custom_modal/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ tf_ts_library(
2323
],
2424
deps = [
2525
":custom_modal",
26+
"//tensorboard/webapp/angular:expect_angular_core_testing",
2627
"@npm//@angular/common",
2728
"@npm//@angular/core",
2829
"@npm//@angular/platform-browser",

tensorboard/webapp/widgets/custom_modal/custom_modal_component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,9 @@ import {
1919
ViewChild,
2020
ElementRef,
2121
HostListener,
22-
ContentChild,
2322
OnInit,
2423
} from '@angular/core';
25-
import {BehaviorSubject, tap} from 'rxjs';
24+
import {BehaviorSubject} from 'rxjs';
2625

2726
export interface ModalContent {
2827
onRender?: () => void;

tensorboard/webapp/widgets/data_table/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ tf_ng_module(
9898
deps = [
9999
":types",
100100
"//tensorboard/webapp/angular:expect_angular_material_button",
101-
"//tensorboard/webapp/angular:expect_angular_material_dialog",
102101
"//tensorboard/webapp/angular:expect_angular_material_icon",
103102
"//tensorboard/webapp/angular:expect_angular_material_input",
104103
"@npm//@angular/common",

tensorboard/webapp/widgets/data_table/column_selector_module.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import {MatInputModule} from '@angular/material/input';
2020
import {MatButtonModule} from '@angular/material/button';
2121
import {ColumnSelectorComponent} from './column_selector_component';
2222
import {FormsModule} from '@angular/forms';
23-
import {MatDialogModule} from '@angular/material/dialog';
2423

2524
@NgModule({
2625
declarations: [ColumnSelectorComponent],
@@ -29,7 +28,6 @@ import {MatDialogModule} from '@angular/material/dialog';
2928
MatIconModule,
3029
MatInputModule,
3130
MatButtonModule,
32-
MatDialogModule,
3331
FormsModule,
3432
],
3533
exports: [ColumnSelectorComponent],

0 commit comments

Comments
 (0)