Skip to content

Commit 1e7f1c9

Browse files
authored
Tweak some patch and upgrade documentation. (#6520)
Make some minor fixes/additions to documentation related to upgrading npm dependencies and generating patch files.
1 parent 165ef3b commit 1e7f1c9

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ to be edited by hand.
246246
247247
4. Rebuild and test TensorBoard to make sure it works:
248248
* `rm -rf node_modules; bazel clean --expunge; yarn`
249-
* `bazel run tensorboard --logdir <your favorite logdir>`
249+
* `bazel run tensorboard -- --logdir <your favorite logdir>`
250250
* `bazel test --test_output=errors tensorboard/webapp/... tensorboard/components/... tensorboard/plugins/...`
251251
252252
## Updating rules_nodejs

patches/README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,14 @@ We use [patch-package](https://www.npmjs.com/package/patch-package) to apply
44
TensorBoard-specific patches to some of our npm/yarn dependencies.
55

66
To regenerate @bazel/concatjs patch:
7-
* `vi "node_modules/@bazel/concatjs/web_test/karma.conf.js"`
7+
* `vi node_modules/@bazel/concatjs/web_test/karma.conf.js`
88
* make edits
99
* `yarn patch-package "@bazel/concatjs"`
10+
* update the WORKSPACE file with the name of the new patch file
1011

12+
13+
To regenerate @angular/build-tooling patch:
14+
* `vi node_modules/@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs`
15+
* make edits
16+
* `yarn patch-package "@angular/build-tooling"`
17+
* update the WORKSPACE file with the name of the new patch file

0 commit comments

Comments
 (0)