Skip to content

Commit 31c61d5

Browse files
authored
Import Fix: Remove DebuggerState from AppState. (#6554)
In #6544 we introduced a dependency on AppState on DebuggerState. This unfortunately fails some internal tests, where certain TensorBoard products do not want to unnecessarily depend on plugin state that they don't use. I've removed DebuggerState from AppState. Fortunately there are no tests or features that require this dependency.
1 parent b408561 commit 31c61d5

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

tensorboard/webapp/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ tf_ng_module(
142142
"app_state.ts",
143143
],
144144
deps = [
145-
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/store:types",
146145
"//tensorboard/webapp/alert/store:types",
147146
"//tensorboard/webapp/app_routing/store:types",
148147
"//tensorboard/webapp/core/store",

tensorboard/webapp/app_state.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ See the License for the specific language governing permissions and
1313
limitations under the License.
1414
==============================================================================*/
1515

16-
import {State as DebuggerState} from '../plugins/debugger_v2/tf_debugger_v2_plugin/store/debugger_types';
1716
import {State as AlertState} from './alert/store/alert_types';
1817
import {State as AppRoutingState} from './app_routing/store/app_routing_types';
1918
import {State as CoreState} from './core/store/core_types';
@@ -35,6 +34,5 @@ export type State = AppRoutingState &
3534
RunsState &
3635
SettingsState &
3736
NotificationState &
38-
DebuggerState &
3937
AlertState &
4038
PersistentSettingsState;

tensorboard/webapp/testing/utils.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,13 @@ import {ALERT_FEATURE_KEY} from '../alert/store/alert_types';
6767
import {PERSISTENT_SETTINGS_FEATURE_KEY} from '../persistent_settings/_redux/persistent_settings_types';
6868
import {SETTINGS_FEATURE_KEY} from '../settings/_redux/settings_types';
6969
import {CORE_FEATURE_KEY} from '../core/store/core_types';
70-
import {DEBUGGER_FEATURE_KEY} from '../../plugins/debugger_v2/tf_debugger_v2_plugin/store/debugger_types';
7170

7271
type PartialOverrides = {
7372
[K in keyof State]?: Partial<State[K]>;
7473
};
7574

7675
export function buildMockState(overrides: PartialOverrides = {}): State {
7776
return {
78-
...buildStateFromDebuggerState(
79-
createDebuggerState(overrides[DEBUGGER_FEATURE_KEY] ?? {})
80-
),
8177
...buildStateFromAlertState(
8278
buildAlertState(overrides[ALERT_FEATURE_KEY] ?? {})
8379
),

0 commit comments

Comments
 (0)