Skip to content

Commit 5146fb8

Browse files
authored
build: export histogram proto declaration in summary proto (#6020)
This is needed to fix internal build after the `HistogramProto` location change in #6010. In OSS we don't need the `tb_proto_library` to actually use the `exports` arg since we could use the `public` symbol (https://developers.google.com/protocol-buffers/docs/proto3#importing_definitions) without additional changes. The signature change for `tb_proto_library` is required internally. Corresponding internal change: cl/485927103 (see cl description for full details).
1 parent f249374 commit 5146fb8

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

tensorboard/compat/proto/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ tb_proto_library(
237237
tb_proto_library(
238238
name = "summary",
239239
srcs = ["summary.proto"],
240+
exports = [":histogram"],
240241
deps = [
241242
":histogram",
242243
":tensor",

tensorboard/defs/protos.bzl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ def tb_proto_library(
2020
deps = [],
2121
visibility = None,
2222
testonly = None,
23-
has_services = False):
23+
has_services = False,
24+
# The `exports` arg is unused here, but required internally for compatibility.
25+
exports = []):
2426
outs_proto = _PyOuts(srcs, grpc = False)
2527
outs_grpc = _PyOuts(srcs, grpc = True) if has_services else []
2628
outs_all = outs_proto + outs_grpc

0 commit comments

Comments
 (0)