Skip to content

Commit 5f44f55

Browse files
authored
Linked Time: Remove step selection overrides when global range selection is toggled (#6262)
## Motivation for features / changes See #6240 for context around why the step selector is being moved to redux. Part of this has involved decoupling card specific step and range selection from the global values. For Googlers see [internal test failures]( https://fusion2.corp.google.com/invocations/88e32921-2cbc-4924-9dcc-986ffaa5f6a2/targets/%2F%2Flearning%2Fbrain%2Ftensorboard%2Fservice%2Ftbcorp%2Fwebtests:linked_time_complex_test_chrome-linux/tests) ## Technical Description of Changes Whenever the global range selection value is changed, I remove all step selection overrides at the reducer level. ## Screenshots of UI changes ![7574630a-d08f-45da-a499-d686cf12fa8c](https://user-images.githubusercontent.com/78179109/226986094-115e1a6e-6598-4b54-8443-3d33c022dad8.gif) ## Detailed steps to verify changes work correctly (as executed by you) 1) Patch #6240 2) Start tensorboard 3) Navigate to localhost:6006 4) Enable global step selection 5) Remove the start fob from a scalar card 6) Enable global range selection 7) Ensure start and end fobs appear on all cards
1 parent 08294c4 commit 5f44f55

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

tensorboard/webapp/metrics/store/metrics_reducers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,6 +1090,7 @@ const reducer = createReducer(
10901090
// again have the "global" state.
10911091
cardStateMap[cardId] = {
10921092
...cardState,
1093+
stepSelectionOverride: CardFeatureOverride.NONE,
10931094
rangeSelectionOverride: CardFeatureOverride.NONE,
10941095
};
10951096
return cardStateMap;

tensorboard/webapp/metrics/store/metrics_reducers_test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3403,9 +3403,11 @@ describe('metrics reducers', () => {
34033403
cardStateMap: {
34043404
card1: {
34053405
rangeSelectionOverride: CardFeatureOverride.OVERRIDE_AS_ENABLED,
3406+
stepSelectionOverride: CardFeatureOverride.OVERRIDE_AS_ENABLED,
34063407
},
34073408
card2: {
34083409
rangeSelectionOverride: CardFeatureOverride.OVERRIDE_AS_DISABLED,
3410+
stepSelectionOverride: CardFeatureOverride.OVERRIDE_AS_DISABLED,
34093411
},
34103412
card3: {},
34113413
},
@@ -3414,12 +3416,15 @@ describe('metrics reducers', () => {
34143416
expect(state2.cardStateMap).toEqual({
34153417
card1: {
34163418
rangeSelectionOverride: CardFeatureOverride.NONE,
3419+
stepSelectionOverride: CardFeatureOverride.NONE,
34173420
},
34183421
card2: {
34193422
rangeSelectionOverride: CardFeatureOverride.NONE,
3423+
stepSelectionOverride: CardFeatureOverride.NONE,
34203424
},
34213425
card3: {
34223426
rangeSelectionOverride: CardFeatureOverride.NONE,
3427+
stepSelectionOverride: CardFeatureOverride.NONE,
34233428
},
34243429
});
34253430
});

0 commit comments

Comments
 (0)