Bug Fix: Remove all forceSvg specific logic (#6244)

## Motivation for features / changes
`forceSvg` being stored to localStorage predates our feature allowing
any feature flag to be stored to localStorage. Unfortunately these two
features work quite poorly together.

The `forceSvg` flag has turned into a kind of virus because it writes
itself to localStorage when it appears in the url. This means that users
who having it enabled sharing a link to another user will cause the
setting to spread.

Now that there is a new way of enabling this feature permanently for
users, I am removing the older method of persisting the flag.

## Technical description of changes


## Screenshots of UI changes
None

## Detailed steps to verify changes work correctly (as executed by you)
1) Start tensorboard
2) Navigate to localhost:6006?showFlags
3) Ensure `forceSvg` is disabled
4) Navigate to localhost:6006?showFlags&forceSvg=true
5) Ensure `forceSvg` is enabled
6) Navigate to localhost:6006?showFlags
7) Ensure `forceSvg` is still disabled

## Alternate designs / implementations considered
I could have just updated the `force_svg_data_source` to stop storing
force_svg differently and potentially migrate users to store `forceSvg`
using the same persistence as other feature flags. However, we do not
believe there are a lot of users that actually need the feature and thus
we would prefer to force the small number of users that need this
feature to re-enable it while rescuing unintentionally effected users.

Author: rileyajones

tensorboard/webapp/feature_flag/BUILD

@@ -8,7 +8,6 @@ tf_ng_module(
         "feature_flag_module.ts",
     ],
     deps = [
-        ":force_svg_data_source",
         "//tensorboard/webapp/angular:expect_angular_common_http",
         "//tensorboard/webapp/feature_flag/effects",
         "//tensorboard/webapp/feature_flag/http",
@@ -22,18 +21,6 @@ tf_ng_module(
     ],
 )
 
-tf_ng_module(
-    name = "force_svg_data_source",
-    srcs = [
-        "force_svg_data_source.ts",
-        "force_svg_data_source_module.ts",
-    ],
-    deps = [
-        "//tensorboard/webapp/webapp_data_source:feature_flag_types",
-        "@npm//@angular/core",
-    ],
-)
-
 tf_ts_library(
     name = "types",
     srcs = [
@@ -53,19 +40,6 @@ tf_ts_library(
     ],
 )
 
-tf_ts_library(
-    name = "test_lib",
-    testonly = True,
-    srcs = [
-        "force_svg_data_source_test.ts",
-    ],
-    deps = [
-        ":force_svg_data_source",
-        "//tensorboard/webapp/angular:expect_angular_core_testing",
-        "@npm//@types/jasmine",
-    ],
-)
-
 tf_ng_web_test_suite(
     name = "karma_test",
     deps = [

tensorboard/webapp/feature_flag/effects/BUILD

@@ -9,7 +9,6 @@ tf_ng_module(
     ],
     deps = [
         "//tensorboard/webapp:tb_polymer_interop_types",
-        "//tensorboard/webapp/feature_flag:force_svg_data_source",
         "//tensorboard/webapp/feature_flag:types",
         "//tensorboard/webapp/feature_flag/actions",
         "//tensorboard/webapp/feature_flag/store",
@@ -33,7 +32,6 @@ tf_ng_module(
         ":effects",
         "//tensorboard/webapp/angular:expect_angular_core_testing",
         "//tensorboard/webapp/angular:expect_ngrx_store_testing",
-        "//tensorboard/webapp/feature_flag:force_svg_data_source",
         "//tensorboard/webapp/feature_flag:testing",
         "//tensorboard/webapp/feature_flag:types",
         "//tensorboard/webapp/feature_flag/actions",

tensorboard/webapp/feature_flag/effects/feature_flag_effects.ts

@@ -25,7 +25,6 @@ import {
   featureFlagOverridesReset,
   partialFeatureFlagsLoaded,
 } from '../actions/feature_flag_actions';
-import {ForceSvgDataSource} from '../force_svg_data_source';
 import {
   getFeatureFlags,
   getFeatureFlagsMetadata,
@@ -58,12 +57,6 @@ export class FeatureFlagEffects {
           featureFlagsMetadata
         );
 
-        if (features.forceSvg != null) {
-          this.forceSvgDataSource.updateForceSvgFlag(features.forceSvg);
-        } else if (this.forceSvgDataSource.getForceSvgFlag()) {
-          features.forceSvg = true;
-        }
-
         return partialFeatureFlagsLoaded({features});
       })
     )
@@ -138,8 +131,7 @@ export class FeatureFlagEffects {
   constructor(
     private readonly actions$: Actions,
     private readonly store: Store<State>,
-    private readonly dataSource: TBFeatureFlagDataSource,
-    private readonly forceSvgDataSource: ForceSvgDataSource
+    private readonly dataSource: TBFeatureFlagDataSource
   ) {}
 
   /** @export */

tensorboard/webapp/feature_flag/effects/feature_flag_effects_test.ts

@@ -29,8 +29,6 @@ import {
   featureFlagOverridesReset,
   partialFeatureFlagsLoaded,
 } from '../actions/feature_flag_actions';
-import {ForceSvgDataSource} from '../force_svg_data_source';
-import {ForceSvgDataSourceModule} from '../force_svg_data_source_module';
 import {FeatureFlagMetadataMap} from '../store/feature_flag_metadata';
 import {
   getFeatureFlags,
@@ -40,21 +38,19 @@ import {
 } from '../store/feature_flag_selectors';
 import {State} from '../store/feature_flag_types';
 import {buildFeatureFlag} from '../testing';
-import {FeatureFlags} from '../types';
 import {FeatureFlagEffects} from './feature_flag_effects';
 
 describe('feature_flag_effects', () => {
   let actions: ReplaySubject<Action>;
   let store: MockStore<State>;
   let dataSource: TestingTBFeatureFlagDataSource;
-  let forceSvgDataSource: ForceSvgDataSource;
   let effects: FeatureFlagEffects;
   let setPolymerFeatureFlagsSpy: jasmine.Spy;
 
   beforeEach(async () => {
     actions = new ReplaySubject<Action>(1);
     await TestBed.configureTestingModule({
-      imports: [TBFeatureFlagTestingModule, ForceSvgDataSourceModule],
+      imports: [TBFeatureFlagTestingModule],
       providers: [
         provideMockActions(actions),
         FeatureFlagEffects,
@@ -74,7 +70,6 @@ describe('feature_flag_effects', () => {
     effects = TestBed.inject(FeatureFlagEffects);
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
     dataSource = TestBed.inject(TestingTBFeatureFlagDataSource);
-    forceSvgDataSource = TestBed.inject(ForceSvgDataSource);
     store.overrideSelector(getIsAutoDarkModeAllowed, false);
     store.overrideSelector(getFeatureFlagsMetadata, FeatureFlagMetadataMap);
   });
@@ -112,56 +107,6 @@ describe('feature_flag_effects', () => {
         }),
       ]);
     });
-
-    it('calls updateForceSvgFlag when getFeatures returns a value for forceSvg', () => {
-      spyOn(dataSource, 'getFeatures').and.returnValue(
-        buildFeatureFlag({
-          forceSvg: true,
-        })
-      );
-      let updateSpy = spyOn(
-        forceSvgDataSource,
-        'updateForceSvgFlag'
-      ).and.stub();
-
-      actions.next(effects.ngrxOnInitEffects());
-
-      expect(recordedActions).toEqual([
-        partialFeatureFlagsLoaded({
-          features: buildFeatureFlag({
-            forceSvg: true,
-          }),
-        }),
-      ]);
-
-      expect(updateSpy).toHaveBeenCalledOnceWith(true);
-    });
-
-    it('gets forceSVG flag from ForceSvgDataSource when getFeatures returns no value for forceSvg', () => {
-      let featureFlags: Partial<FeatureFlags> = buildFeatureFlag();
-      delete featureFlags.forceSvg;
-      spyOn(dataSource, 'getFeatures').and.returnValue(featureFlags);
-      let updateSpy = spyOn(
-        forceSvgDataSource,
-        'updateForceSvgFlag'
-      ).and.stub();
-      let getSpy = spyOn(forceSvgDataSource, 'getForceSvgFlag').and.returnValue(
-        true
-      );
-
-      actions.next(effects.ngrxOnInitEffects());
-
-      expect(recordedActions).toEqual([
-        partialFeatureFlagsLoaded({
-          features: buildFeatureFlag({
-            forceSvg: true,
-          }),
-        }),
-      ]);
-
-      expect(getSpy).toHaveBeenCalledOnceWith();
-      expect(updateSpy).toHaveBeenCalledTimes(0);
-    });
   });
 
   describe('updatePolymerFeatureFlags$', () => {

tensorboard/webapp/feature_flag/feature_flag_module.ts

@@ -24,7 +24,6 @@ import {
 } from '../persistent_settings';
 import {TBFeatureFlagModule} from '../webapp_data_source/tb_feature_flag_module';
 import {FeatureFlagEffects} from './effects/feature_flag_effects';
-import {ForceSvgDataSourceModule} from './force_svg_data_source_module';
 import {FeatureFlagHttpInterceptor} from './http/feature_flag_http_interceptor';
 import {reducers} from './store/feature_flag_reducers';
 import {getEnableDarkModeOverride} from './store/feature_flag_selectors';
@@ -47,7 +46,6 @@ export function getThemeSettingSelector() {
 
 @NgModule({
   imports: [
-    ForceSvgDataSourceModule,
     TBFeatureFlagModule,
     StoreModule.forFeature(
       FEATURE_FLAG_FEATURE_KEY,