Upgrade rules_nodejs to 5.7.0, rules_sass to 1.55, minimum bazel to 4.2.2. (#5977)

Upgrades rule_nodejs dependency to 5.7.0.

This also requires upgrading:
* npm @bazel dependencies to 5.7.0
* rules_sass to its latest version 1.55.0.
* minimum bazel version to 4.2.2

Following two sets of instructions:
* General instructions for migration to 5.X major release:
https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0
* Instructions for 5.7.0 specifically:
https://github.com/bazelbuild/rules_nodejs/releases/tag/5.7.0

Other notable things:
* yarn_install's exports_directories_only property now defaults to True.
We must set this to False in order to remain compatible with ts_library
  * See: https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0#exports_directories_only

* No longer need to override node_version as rules_nodejs default
version of node is now 16.12.0.
  * See: https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0#updated-defaults
  * We were overriding this only because rules_nodejs defaul version of
node was too old.

* ts_library has moved from @bazel/typescript to @bazel/concatjs
  * See: https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0#ts_library

* rules_sass upgrade was necessary to avoid SassCompiler hanging
indefinitely. Builds were not completing.

* bazel version upgrade was not necessary but does match the minimum version
specified by rules_nodejs:
  * See: https://github.com/bazelbuild/rules_nodejs/blob/5.7.0/index.bzl#L96

Author: bmd3k

.github/workflows/ci.yml

@@ -22,8 +22,8 @@ on:
 env:
   # Keep this Bazel version in sync with the `versions.check` directive
   # in our WORKSPACE file.
-  BAZEL_VERSION: '4.0.0'
-  BAZEL_SHA256SUM: '7bee349a626281fc8b8d04a7a0b0358492712377400ab12533aeb39c2eb2b901'
+  BAZEL_VERSION: '4.2.2'
+  BAZEL_SHA256SUM: '11dea6c7cfd866ed520af19a6bb1d952f3e9f4ee60ffe84e63c0825d95cb5859'
   BUILDTOOLS_VERSION: '3.0.0'
   BUILDIFIER_SHA256SUM: 'e92a6793c7134c5431c58fbc34700664f101e5c9b1c1fcd93b97978e8b7f88db'
   BUILDOZER_SHA256SUM: '3d58a0b6972e4535718cdd6c12778170ea7382de7c75bc3728f5719437ffb84d'

WORKSPACE

@@ -25,7 +25,7 @@ load("@bazel_skylib//lib:versions.bzl", "versions")
 
 # Keep this version in sync with:
 #  * The BAZEL environment variable defined in .github/workflows/ci.yml, which is used for CI and nightly builds.
-versions.check(minimum_bazel_version = "4.0.0")
+versions.check(minimum_bazel_version = "4.2.2")
 
 http_archive(
     name = "io_bazel_rules_webtesting",
@@ -64,27 +64,27 @@ rules_closure_dependencies(
 
 http_archive(
     name = "build_bazel_rules_nodejs",
-    sha256 = "d63ecec7192394f5cc4ad95a115f8a6c9de55c60d56c1f08da79c306355e4654",
+    sha256 = "c29944ba9b0b430aadcaf3bf2570fece6fc5ebfb76df145c6cdad40d65c20811",
     urls = [
-        "http://mirror.tensorflow.org/github.com/bazelbuild/rules_nodejs/releases/download/4.6.1/rules_nodejs-4.6.1.tar.gz",
-        "https://github.com/bazelbuild/rules_nodejs/releases/download/4.6.1/rules_nodejs-4.6.1.tar.gz",
+        "http://mirror.tensorflow.org/github.com/bazelbuild/rules_nodejs/releases/download/5.7.0/rules_nodejs-5.7.0.tar.gz",
+        "https://github.com/bazelbuild/rules_nodejs/releases/download/5.7.0/rules_nodejs-5.7.0.tar.gz",
     ],
 )
 
-load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")
+load("@build_bazel_rules_nodejs//:repositories.bzl", "build_bazel_rules_nodejs_dependencies")
 
-node_repositories(
-    node_version = "12.21.0",
-)
+build_bazel_rules_nodejs_dependencies()
+
+load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
 
 yarn_install(
     name = "npm",
+    # "Some rules only work by referencing labels nested inside npm packages
+    # and therefore require turning off exports_directories_only."
+    # This includes "ts_library".
+    # See: https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0#exports_directories_only
+    exports_directories_only = False,
     package_json = "//:package.json",
-    # Opt out of symlinking local node_modules folder into bazel internal
-    # directory.  Symlinking is incompatible with our toolchain which often
-    # removes source directory without `bazel clean` which creates broken
-    # symlink into node_modules folder.
-    symlink_node_modules = False,
     yarn_lock = "//:yarn.lock",
 )
 
@@ -94,13 +94,18 @@ load("@build_bazel_rules_nodejs//toolchains/esbuild:esbuild_repositories.bzl", "
 
 esbuild_repositories(npm_repository = "npm")
 
+# rules_sass release information is difficult to find but it does seem to
+# regularly release with same cadence and version as core sass.
+# We typically upgrade this library whenever we upgrade rules_nodejs.
+#
+# rules_sass 1.55.0: https://github.com/bazelbuild/rules_sass/tree/1.55.0
 http_archive(
     name = "io_bazel_rules_sass",
-    sha256 = "ee6d527550d42af182673c3718da98bb9205cabdeb08eacc0e3767fa3f2b051a",
-    strip_prefix = "rules_sass-1.49.11",
+    sha256 = "1ea0103fa6adcb7d43ff26373b5082efe1d4b2e09c4f34f8a8f8b351e9a8a9b0",
+    strip_prefix = "rules_sass-1.55.0",
     urls = [
-        "http://mirror.tensorflow.org/github.com/bazelbuild/rules_sass/archive/1.49.11.zip",
-        "https://github.com/bazelbuild/rules_sass/archive/1.49.11.zip",
+        "http://mirror.tensorflow.org/github.com/bazelbuild/rules_sass/archive/1.55.0.zip",
+        "https://github.com/bazelbuild/rules_sass/archive/1.55.0.zip",
     ],
 )
 

package.json

@@ -31,11 +31,11 @@
     "@angular/cli": "^12.2.0",
     "@angular/compiler": "^12.2.0",
     "@angular/compiler-cli": "^12.2.0",
-    "@bazel/concatjs": "^4.6.1",
-    "@bazel/esbuild": "^4.6.2",
+    "@bazel/concatjs": "5.7.0",
+    "@bazel/esbuild": "5.7.0",
     "@bazel/ibazel": "^0.15.9",
-    "@bazel/jasmine": "^4.6.1",
-    "@bazel/typescript": "^4.6.1",
+    "@bazel/jasmine": "5.7.0",
+    "@bazel/typescript": "5.7.0",
     "@types/d3": "5.7.2",
     "@types/jasmine": "^3.8.2",
     "@types/lodash": "^4.14.172",

tensorboard/defs/BUILD

@@ -1,6 +1,6 @@
 load("//tensorboard/defs:protos.bzl", "tb_proto_library")
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("@npm//@bazel/typescript:index.bzl", "ts_library")
+load("@npm//@bazel/concatjs:index.bzl", "ts_library")
 
 package(default_visibility = ["//tensorboard:internal"])
 
@@ -50,14 +50,15 @@ ts_library(
 # Custom ts_library compiler that runs tsc_wrapped with angular/compiler-cli statically linked
 # This can be used with worker mode because we don't need the linker at runtime to make
 # the angular plugin loadable
-# Just a clone of @npm//@bazel/typescript/bin:tsc_wrapped with added deps
+# Just a clone of @npm//@bazel/concatjs/bin:tsc_wrapped with added deps
 nodejs_binary(
     name = "tsc_wrapped_with_angular",
     data = [
         "@npm//@angular/compiler-cli",
+        "@npm//@bazel/concatjs",
         "@npm//@bazel/typescript",
     ],
-    entry_point = "@npm//:node_modules/@bazel/typescript/internal/tsc_wrapped/tsc_wrapped.js",
+    entry_point = "@npm//:node_modules/@bazel/concatjs/internal/tsc_wrapped/tsc_wrapped.js",
     # Disables the Bazel node modules linker. The node module linker is unreliable for the
     # persistent worker executable, as it would rely on the `node_modules/` folder in the
     # execroot that can be shared in non-sandbox environments or for persistent workers.

tensorboard/defs/defs.bzl

@@ -14,9 +14,9 @@
 """External-only delegates for various BUILD rules."""
 
 load("@io_bazel_rules_sass//:defs.bzl", "npm_sass_library", "sass_binary", "sass_library")
-load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite")
+load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite", "ts_library")
 load("@npm//@bazel/esbuild:index.bzl", "esbuild")
-load("@npm//@bazel/typescript:index.bzl", "ts_config", "ts_library")
+load("@npm//@bazel/typescript:index.bzl", "ts_config")
 
 
 def tensorboard_webcomponent_library(**kwargs):

yarn.lock

@@ -359,48 +359,47 @@
     "@babel/helper-validator-identifier" "^7.18.6"
     to-fast-properties "^2.0.0"
 
-"@bazel/concatjs@^4.6.1":
-  version "4.6.2"
-  resolved "https://registry.yarnpkg.com/@bazel/concatjs/-/concatjs-4.6.2.tgz#f034a33a2cb5b8a5426c3166ed6ea5857cb31940"
-  integrity sha512-5wpASLPgWU+ti7+/iHquym0mY1lFZkkNUlHPzCjSOBolzdSWO9yFO/S5k2agzULNbNrZInI9IErakyc6K3xvog==
+"@bazel/concatjs@5.7.0":
+  version "5.7.0"
+  resolved "https://registry.yarnpkg.com/@bazel/concatjs/-/concatjs-5.7.0.tgz#ee9e2369ceabca7fdba9ee1539ddcdf0fc57a283"
+  integrity sha512-FlUthrDl9oq8HYP6mXVvhJ1dGCEgZ9TOsHJ6aab56bwBJWNDRwWuCYElozZO/Lgu7NB6GkD3CGG8HBjxYM+ZZg==
   dependencies:
     protobufjs "6.8.8"
     source-map-support "0.5.9"
     tsutils "3.21.0"
 
-"@bazel/esbuild@^4.6.2":
-  version "4.6.2"
-  resolved "https://registry.yarnpkg.com/@bazel/esbuild/-/esbuild-4.6.2.tgz#1be88b6c4c07cabb2dd84a698d5be0f32de934f4"
-  integrity sha512-VqmeIlEDq7tVNpIk88zS3DZSAV1F1VN92IBPekKuQqIU6PTt3+iID/v4lkK80SwFBthF4pi/PG0PPaulIe/qGA==
+"@bazel/esbuild@5.7.0":
+  version "5.7.0"
+  resolved "https://registry.yarnpkg.com/@bazel/esbuild/-/esbuild-5.7.0.tgz#8eb01e18994553f24e08df175fd43d0298bfc51d"
+  integrity sha512-5QQVa9gZ7sOVA7b9HdSXLvDuZ8crqubGJkEsNUjSh1pSzHuyMIqKYbYaEhCFrhfk4M/XoTy/BkIER0bJSZYjMw==
 
 "@bazel/ibazel@^0.15.9":
   version "0.15.10"
   resolved "https://registry.yarnpkg.com/@bazel/ibazel/-/ibazel-0.15.10.tgz#cf0cff1aec6d8e7bb23e1fc618d09fbd39b7a13f"
   integrity sha512-0v+OwCQ6fsGFa50r6MXWbUkSGuWOoZ22K4pMSdtWiL5LKFIE4kfmMmtQS+M7/ICNwk2EIYob+NRreyi/DGUz5A==
 
-"@bazel/jasmine@^4.6.1":
-  version "4.6.2"
-  resolved "https://registry.yarnpkg.com/@bazel/jasmine/-/jasmine-4.6.2.tgz#0cda13b88b62345ea0f3a52b24b903b29e90a4cd"
-  integrity sha512-T5YOIy800khE+NXf0IsV1KcQjPjppf9CzSBe68LluFg+cgnF59GHn9qnlz4Ml9/L6bx5TQxG3yWbWY/jiAwziQ==
+"@bazel/jasmine@5.7.0":
+  version "5.7.0"
+  resolved "https://registry.yarnpkg.com/@bazel/jasmine/-/jasmine-5.7.0.tgz#85b136f0e671e17d7907ab7bc725648c3267dc1d"
+  integrity sha512-ZUFyNk1PxMtbeQkF3JshuOpdEpNczKLP2es70Kp7oLZfPQ5DySpGX07utuM/o3gkawdZGVtRMFF+UbQa/wG5mA==
   dependencies:
     c8 "~7.5.0"
     jasmine-reporters "~2.5.0"
 
-"@bazel/typescript@^4.6.1":
-  version "4.6.2"
-  resolved "https://registry.yarnpkg.com/@bazel/typescript/-/typescript-4.6.2.tgz#9f07b6f8cfb6b0a0e228e5971de412911c910a90"
-  integrity sha512-AUF7kq82bP6DX9Brihr/eQqvNccxVfSXosFxt80h94og5cmMyoc/euXha6rxlOBP3yWXmSo+/qjzO7o8PWJduQ==
+"@bazel/typescript@5.7.0":
+  version "5.7.0"
+  resolved "https://registry.yarnpkg.com/@bazel/typescript/-/typescript-5.7.0.tgz#3f888c603bf5f159dfb4c0c38584fb31d248d5a2"
+  integrity sha512-5c06vi2rQqd75GieqYGsNVon3tnkvbjMlVLJuwJ5/VtC9uOXKlCwrqxV8tbx789PTTtACNYzwKJTVW++58tgDA==
   dependencies:
-    "@bazel/worker" "4.6.2"
-    protobufjs "6.8.8"
+    "@bazel/worker" "5.7.0"
     semver "5.6.0"
     source-map-support "0.5.9"
     tsutils "3.21.0"
 
-"@bazel/worker@4.6.2":
-  version "4.6.2"
-  resolved "https://registry.yarnpkg.com/@bazel/worker/-/worker-4.6.2.tgz#0bd105344533335327c2edfa3fc65b04c39cdea8"
-  integrity sha512-DLpN6iQAH6uiUraAs4CESyqs60u55fcKmYgOOVObGuLSQQuX49Lw7XRIN90NibRPwpbBDQichWE3zfra0yKTTw==
+"@bazel/worker@5.7.0":
+  version "5.7.0"
+  resolved "https://registry.yarnpkg.com/@bazel/worker/-/worker-5.7.0.tgz#d121261ee1833c5f5858f818f0e4d9a2d8e2c3c5"
+  integrity sha512-VqTG+0gsgXM07q+HiQcSAggNnAzjLei8lzlJQ+mey12KGI4AbNJ1vxlk2pnw9BZdckfe2rRzwkF44B5SNqIgSQ==
   dependencies:
     google-protobuf "^3.6.1"