Bug Fix: Start using expect_angular_legacy_material_checkbox (#6547)

## Motivation for features / changes
#6493 Broke our internal sync Googlers see
[cl/557499468](http://cl/557499468)

The issue is related to our internal Angular component migration. New
components are not allowed to rely on the legacy components. Due to this
the new component added in #6493 uses the non legacy checkbox. However,
our dependency remapping always remaps dependencies on material_checkbox
to legacy_material_checkbox.

To fix this I am changing the name of the remapping rule in
[cl/557515881](http://cl/557515881) and adjusting all the OSS usage
EXCEPT for the usage in filter_dialog.

[cl/557590954](http://cl/557590954) is also required to map the testing
dependency needed to use `MatCheckboxHarness`

Author: rileyajones

tensorboard/webapp/angular/BUILD

@@ -87,6 +87,24 @@ tf_ts_library(
     ],
 )
 
+# This is a dummy rule used as a @angular/material/legeacy_checkbox dependency.
+tf_ts_library(
+    name = "expect_angular_legacy_material_checkbox",
+    srcs = [],
+    deps = [
+        "@npm//@angular/material",
+    ],
+)
+
+# This is a dummy rule used as a @angular/material/checkbox/testing dependency.
+tf_ts_library(
+    name = "expect_angular_material_checkbox_testing",
+    srcs = [],
+    deps = [
+        "@npm//@angular/material",
+    ],
+)
+
 # This is a dummy rule used as a @angular/material/button dependency.
 tf_ts_library(
     name = "expect_angular_material_button",

tensorboard/webapp/metrics/views/right_pane/BUILD

@@ -27,9 +27,9 @@ tf_ng_module(
     deps = [
         "//tensorboard/webapp:app_state",
         "//tensorboard/webapp:selectors",
+        "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_button",
         "//tensorboard/webapp/angular:expect_angular_material_button_toggle",
-        "//tensorboard/webapp/angular:expect_angular_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_icon",
         "//tensorboard/webapp/angular:expect_angular_material_select",
         "//tensorboard/webapp/angular:expect_angular_material_slider",
@@ -58,8 +58,8 @@ tf_ts_library(
         "//tensorboard/webapp:app_state",
         "//tensorboard/webapp:selectors",
         "//tensorboard/webapp/angular:expect_angular_core_testing",
+        "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_button_toggle",
-        "//tensorboard/webapp/angular:expect_angular_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_select",
         "//tensorboard/webapp/angular:expect_angular_material_slider",
         "//tensorboard/webapp/angular:expect_angular_platform_browser_animations",

tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD

@@ -26,7 +26,7 @@ tf_ng_module(
     deps = [
         "//tensorboard/webapp:app_state",
         "//tensorboard/webapp:selectors",
-        "//tensorboard/webapp/angular:expect_angular_material_checkbox",
+        "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_tabs",
         "//tensorboard/webapp/metrics:types",
         "//tensorboard/webapp/metrics/actions",

tensorboard/webapp/runs/views/runs_table/BUILD

@@ -81,8 +81,8 @@ tf_ng_module(
         "//tensorboard/webapp:selectors",
         "//tensorboard/webapp/alert",
         "//tensorboard/webapp/alert/actions",
+        "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_button",
-        "//tensorboard/webapp/angular:expect_angular_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_dialog",
         "//tensorboard/webapp/angular:expect_angular_material_form_field",
         "//tensorboard/webapp/angular:expect_angular_material_icon",
@@ -140,7 +140,7 @@ tf_ts_library(
         "//tensorboard/webapp/alert/actions",
         "//tensorboard/webapp/angular:expect_angular_cdk_overlay",
         "//tensorboard/webapp/angular:expect_angular_core_testing",
-        "//tensorboard/webapp/angular:expect_angular_material_checkbox",
+        "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_dialog",
         "//tensorboard/webapp/angular:expect_angular_material_input",
         "//tensorboard/webapp/angular:expect_angular_material_menu",

tensorboard/webapp/settings/_views/BUILD

@@ -18,8 +18,8 @@ tf_ng_module(
     ],
     deps = [
         "//tensorboard/webapp:tb_polymer_interop_types",
+        "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_button",
-        "//tensorboard/webapp/angular:expect_angular_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_dialog",
         "//tensorboard/webapp/angular:expect_angular_material_icon",
         "//tensorboard/webapp/angular:expect_angular_material_input",
@@ -44,8 +44,8 @@ tf_ts_library(
         ":_views",
         "//tensorboard/webapp/angular:expect_angular_cdk_overlay",
         "//tensorboard/webapp/angular:expect_angular_core_testing",
+        "//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_button",
-        "//tensorboard/webapp/angular:expect_angular_material_checkbox",
         "//tensorboard/webapp/angular:expect_angular_material_dialog",
         "//tensorboard/webapp/angular:expect_angular_material_icon",
         "//tensorboard/webapp/angular:expect_angular_material_input",

tensorboard/webapp/widgets/data_table/BUILD

@@ -182,6 +182,7 @@ tf_ts_library(
         "//tensorboard/webapp/angular:expect_angular_cdk_testing_testbed",
         "//tensorboard/webapp/angular:expect_angular_core_testing",
         "//tensorboard/webapp/angular:expect_angular_material_checkbox",
+        "//tensorboard/webapp/angular:expect_angular_material_checkbox_testing",
         "//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
         "//tensorboard/webapp/testing:mat_icon",
         "//tensorboard/webapp/widgets/custom_modal",