Skip to content

Commit 81e1393

Browse files
authored
Remove strict_deps = False and update dependencies in some sass rules. (#6818)
Googlers see cl/617525193. Also ran `buildifier` to format BUILD files. (Linter step was failing from CI run for this change).
1 parent 04a064f commit 81e1393

File tree

8 files changed

+3
-41
lines changed
  • tensorboard

8 files changed

+3
-41
lines changed

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ tf_sass_binary(
1616
tf_sass_binary(
1717
name = "graph_op_styles",
1818
src = "graph_op_component.scss",
19-
strict_deps = False,
2019
deps = [
2120
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common:style_lib",
21+
"//tensorboard/webapp:angular_material_sass_deps",
2222
"//tensorboard/webapp/theme",
2323
],
2424
)

tensorboard/webapp/alert/views/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ package(default_visibility = ["//tensorboard:internal"])
55
tf_sass_binary(
66
name = "alert_display_snackbar_styles",
77
src = "alert_display_snackbar_container.scss",
8-
strict_deps = False,
9-
deps = ["//tensorboard/webapp/theme"],
108
)
119

1210
tf_ng_module(

tensorboard/webapp/metrics/views/card_renderer/BUILD

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ tf_ng_module(
7979
tf_sass_binary(
8080
name = "histogram_card_styles",
8181
src = "histogram_card_component.scss",
82-
strict_deps = False,
8382
deps = [
84-
"//tensorboard/webapp:angular_material_sass_deps",
8583
"//tensorboard/webapp/metrics/views:metrics_common_styles",
8684
"//tensorboard/webapp/theme",
8785
],
@@ -256,8 +254,8 @@ tf_ts_library(
256254
tf_sass_binary(
257255
name = "scalar_card_styles",
258256
src = "scalar_card_component.scss",
259-
strict_deps = False,
260257
deps = [
258+
"//tensorboard/webapp:angular_material_sass_deps",
261259
"//tensorboard/webapp/metrics/views:metrics_common_styles",
262260
"//tensorboard/webapp/theme",
263261
],
@@ -266,21 +264,11 @@ tf_sass_binary(
266264
tf_sass_binary(
267265
name = "scalar_card_fob_controller_styles",
268266
src = "scalar_card_fob_controller.scss",
269-
strict_deps = False,
270-
deps = [
271-
"//tensorboard/webapp/metrics/views:metrics_common_styles",
272-
"//tensorboard/webapp/theme",
273-
],
274267
)
275268

276269
tf_sass_binary(
277270
name = "scalar_card_data_table_styles",
278271
src = "scalar_card_data_table.scss",
279-
strict_deps = False,
280-
deps = [
281-
"//tensorboard/webapp/metrics/views:metrics_common_styles",
282-
"//tensorboard/webapp/theme",
283-
],
284272
)
285273

286274
tf_ng_module(
@@ -372,11 +360,7 @@ tf_ng_module(
372360
tf_sass_binary(
373361
name = "scalar_card_line_chart_styles",
374362
src = "scalar_card_line_chart_component.scss",
375-
strict_deps = False,
376-
deps = [
377-
"//tensorboard/webapp/metrics/views:metrics_common_styles",
378-
"//tensorboard/webapp/theme",
379-
],
363+
deps = ["//tensorboard/webapp/theme"],
380364
)
381365

382366
tf_ng_module(

tensorboard/webapp/metrics/views/main_view/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ tf_sass_binary(
2424
tf_sass_binary(
2525
name = "filtered_view_component_styles",
2626
src = "filtered_view_component.scss",
27-
strict_deps = False,
2827
deps = [
29-
"//tensorboard/webapp:angular_material_sass_deps",
3028
"//tensorboard/webapp/metrics/views:metrics_common_styles",
3129
"//tensorboard/webapp/theme",
3230
],

tensorboard/webapp/widgets/card_fob/BUILD

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@ tf_sass_binary(
1414
tf_sass_binary(
1515
name = "card_fob_controller_styles",
1616
src = "card_fob_controller_component.scss",
17-
strict_deps = False,
18-
deps = [
19-
"//tensorboard/webapp:angular_material_sass_deps",
20-
"//tensorboard/webapp/theme",
21-
],
2217
)
2318

2419
tf_ng_module(

tensorboard/webapp/widgets/data_table/BUILD

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,11 @@ tf_sass_binary(
2323
tf_sass_binary(
2424
name = "content_cell_styles",
2525
src = "content_cell_component.scss",
26-
strict_deps = False,
27-
deps = [
28-
"//tensorboard/webapp:angular_material_sass_deps",
29-
],
3026
)
3127

3228
tf_sass_binary(
3329
name = "data_table_header_styles",
3430
src = "data_table_header_component.scss",
35-
strict_deps = False,
36-
deps = [
37-
"//tensorboard/webapp:angular_material_sass_deps",
38-
"//tensorboard/webapp/theme",
39-
],
4031
)
4132

4233
tf_sass_binary(

tensorboard/webapp/widgets/line_chart_v2/sub_view/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ tf_sass_binary(
1414
tf_sass_binary(
1515
name = "line_chart_interactive_view_styles",
1616
src = "line_chart_interactive_view.scss",
17-
strict_deps = False,
18-
deps = ["//tensorboard/webapp/theme"],
1917
)
2018

2119
tf_ng_module(

tensorboard/webapp/widgets/text/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ licenses(["notice"])
77
tf_sass_binary(
88
name = "truncated_path_styles",
99
src = "truncated_path_component.scss",
10-
strict_deps = False,
11-
deps = ["//tensorboard/webapp/theme"],
1210
)
1311

1412
tf_ng_module(

0 commit comments

Comments
 (0)