Skip to content

Commit 854f969

Browse files
authored
Embedded Single Card: line chart modifications (#6498)
Make variable modifications on the scalar card line chart for eventual single card usage.
1 parent 3153e8d commit 854f969

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

tensorboard/webapp/metrics/views/card_renderer/scalar_card_line_chart_component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ export class ScalarCardLineChartComponent {
5757
readonly RendererType = RendererType;
5858
readonly ScaleType = ScaleType;
5959

60-
@Input() cardId!: string;
6160
@Input() seriesMetadataMap!: ScalarCardSeriesMetadataMap;
6261
@Input() seriesData!: ScalarCardDataSeries[];
6362
@Input() ignoreOutliers!: boolean;

tensorboard/webapp/metrics/views/card_renderer/scalar_card_line_chart_container.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ import {ScalarCardLineChartComponent} from './scalar_card_line_chart_component';
6565
selector: 'scalar-card-line-chart',
6666
template: `
6767
<scalar-card-line-chart-component
68-
[cardId]="cardId"
6968
[seriesMetadataMap]="seriesMetadataMap"
7069
[seriesData]="seriesData"
7170
[ignoreOutliers]="ignoreOutliers$ | async"
@@ -76,7 +75,7 @@ import {ScalarCardLineChartComponent} from './scalar_card_line_chart_component';
7675
[useDarkMode]="useDarkMode$ | async"
7776
[tooltipTemplate]="tooltipTemplate"
7877
[minMaxStep]="minMaxStep"
79-
[stepOrLinkedTimeSelection]="stepOrLinkedTimeSelection$ | async"
78+
[stepOrLinkedTimeSelection]="stepOrLinkedTimeSelection"
8079
[forceSvg]="forceSvg$ | async"
8180
[userViewBox]="userViewBox$ | async"
8281
(onTimeSelectionChanged)="onTimeSelectionChanged($event)"
@@ -103,6 +102,7 @@ export class ScalarCardLineChartContainer
103102
@Input() seriesMetadataMap!: ScalarCardSeriesMetadataMap;
104103
@Input() seriesData!: ScalarCardDataSeries[];
105104
@Input() minMaxStep!: MinMaxStep;
105+
@Input() stepOrLinkedTimeSelection!: TimeSelection;
106106

107107
@Input() xAxisType?: XAxisType;
108108
@Input() yScaleType?: ScaleType = ScaleType.LINEAR;
@@ -114,7 +114,6 @@ export class ScalarCardLineChartContainer
114114
scalarCardLineChart?: ScalarCardLineChartComponent;
115115

116116
loadState$?: Observable<DataLoadState>;
117-
stepOrLinkedTimeSelection$?: Observable<TimeSelection | undefined>;
118117
userViewBox$?: Observable<Extent | null>;
119118
rangeEnabled$?: Observable<boolean>;
120119

@@ -156,11 +155,6 @@ export class ScalarCardLineChartContainer
156155

157156
this.loadState$ = this.store.select(getCardLoadState, this.cardId);
158157

159-
this.stepOrLinkedTimeSelection$ = this.store.select(
160-
getMetricsCardTimeSelection,
161-
this.cardId
162-
);
163-
164158
this.rangeEnabled$ = this.store.select(
165159
getMetricsCardRangeSelectionEnabled,
166160
this.cardId

0 commit comments

Comments
 (0)