Skip to content

Commit 9fb5e24

Browse files
authored
chore: TypeScript 4.8 suppress comment (#6037)
Internal code health LSC. Adding comments to suppress ts 4.8 strictNullCheck. We still need to clean up the type mismatch (`Settings` to `PersistableSettings`)
1 parent 53e6d9b commit 9fb5e24

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

tensorboard/webapp/persistent_settings/persistent_settings_config_module.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,19 @@ import {
2020

2121
@NgModule()
2222
export class PersistentSettingsConfigModule<State, Settings> {
23+
// @ts-ignore(go/ts48upgrade) Fix code and remove this comment. Error:
24+
// TS2344: Type 'Settings' does not satisfy the constraint
25+
// 'PersistableSettings'.
2326
private readonly globalSettingSelectors: SettingSelector<State, Settings>[] =
2427
[];
2528

2629
constructor(
2730
@Optional()
2831
@Inject(GLOBAL_PERSISTENT_SETTINGS_TOKEN)
2932
globalSettingSelectorFactories: Array<
33+
// @ts-ignore(go/ts48upgrade) Fix code and remove this
34+
// comment. Error: TS2344: Type 'Settings' does not satisfy
35+
// the constraint 'PersistableSettings'.
3036
() => SettingSelector<State, Settings>
3137
> | null
3238
) {
@@ -41,6 +47,9 @@ export class PersistentSettingsConfigModule<State, Settings> {
4147
/**
4248
* Returns Ngrx selectors for getting global setting values.
4349
*/
50+
// @ts-ignore(go/ts48upgrade) Fix code and remove this comment. Error:
51+
// TS2344: Type 'Settings' does not satisfy the constraint
52+
// 'PersistableSettings'.
4453
getGlobalSettingSelectors(): SettingSelector<State, Settings>[] {
4554
return this.globalSettingSelectors ?? [];
4655
}
@@ -69,6 +78,9 @@ export class PersistentSettingsConfigModule<State, Settings> {
6978
* export class MyModule {}
7079
*/
7180
static defineGlobalSetting<State, Settings>(
81+
// @ts-ignore(go/ts48upgrade) Fix code and remove this comment. Error:
82+
// TS2344: Type 'Settings' does not satisfy the constraint
83+
// 'PersistableSettings'.
7284
selectorFactory: () => SettingSelector<State, Settings>
7385
): ModuleWithProviders<PersistentSettingsConfigModule<any, {}>> {
7486
return {

0 commit comments

Comments
 (0)