Skip to content

Commit a8332c0

Browse files
authored
Linked Time: Removed old customVisTemplate that is no longer used (#5912)
* Motivation for features / changes The new implementation of Linked time moved away from this template but it has not been removed. This PR has no visible change in UI or features but removes a lot of unused code. * Technical description of changes We have now switched over to using the lineChartCustomXAxisVis for all linked time needs.
1 parent d20c118 commit a8332c0

File tree

3 files changed

+0
-59
lines changed

3 files changed

+0
-59
lines changed

tensorboard/webapp/metrics/views/card_renderer/scalar_card_component.ng.html

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@
113113
[useDarkMode]="useDarkMode"
114114
(onViewBoxOverridden)="isViewBoxOverridden = $event"
115115
(viewBoxChanged)="onLineChartZoom.emit($event)"
116-
[customVisTemplate]="lineChartCustomVis"
117116
[customChartOverlayTemplate]="lineChartCustomXAxisVis"
118117
></line-chart>
119118
<ng-template
@@ -182,45 +181,6 @@
182181
</scalar-card-data-table>
183182
</div>
184183
</ng-container>
185-
<ng-template
186-
#lineChartCustomVis
187-
let-viewExtent="viewExtent"
188-
let-domDim="domDimension"
189-
let-xScale="xScale"
190-
>
191-
<ng-container *ngIf="stepOrLinkedTimeSelection">
192-
<div
193-
[ngClass]="{
194-
'out-of-selected-time': true,
195-
start: true,
196-
range: !!stepOrLinkedTimeSelection.end?.step
197-
}"
198-
[style.right]="
199-
xScale.forward(
200-
viewExtent.x,
201-
[domDim.width, 0],
202-
stepOrLinkedTimeSelection.start.step
203-
) + 'px'
204-
"
205-
></div>
206-
<div
207-
*ngIf="stepOrLinkedTimeSelection.end?.step"
208-
[ngClass]="{
209-
'out-of-selected-time': true,
210-
end: true,
211-
range: true
212-
}"
213-
[style.left]="
214-
xScale.forward(
215-
viewExtent.x,
216-
[0, domDim.width],
217-
stepOrLinkedTimeSelection.end?.step
218-
) + 'px'
219-
"
220-
></div>
221-
</ng-container>
222-
</ng-template>
223-
224184
<ng-template
225185
#lineChartCustomXAxisVis
226186
let-viewExtent="viewExtent"

tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ng.html

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,6 @@
5353
(onViewExtentChange)="onViewBoxChanged($event)"
5454
(onViewExtentReset)="viewBoxReset()"
5555
></line-chart-interactive-view>
56-
<div *ngIf="customVisTemplate" class="custom-vis">
57-
<ng-container
58-
[ngTemplateOutlet]="customVisTemplate"
59-
[ngTemplateOutletContext]="{
60-
xScale: xScale,
61-
yScale: yScale,
62-
domDimension: domDimensions.main,
63-
viewExtent: viewBox
64-
}"
65-
></ng-container>
66-
</div>
6756
</div>
6857
<div class="y-axis" #yAxis>
6958
<line-chart-axis

tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,6 @@ export class LineChartComponent
9191
@ViewChild('chartEl', {static: false, read: ElementRef})
9292
private chartEl?: ElementRef<HTMLCanvasElement | SVGElement>;
9393

94-
/**
95-
* Optional ngTemplate that renders on top of line chart (not axis). This
96-
* template is rendered on top of interactive layer and can mask other
97-
* contents. Do note that this component may not intercept pointer-events.
98-
*/
99-
@Input()
100-
customVisTemplate?: TemplateRef<TemplateContext>;
101-
10294
@Input()
10395
customChartOverlayTemplate?: TemplateRef<
10496
TemplateContext & {formatter: Formatter}

0 commit comments

Comments
 (0)