Remove deprecated call to flatDoc.normalize (#7011)

rileyajones · web-flow · commit b0a4e02c98a8 · 2025-07-08T16:43:38.000-07:00
## Motivation for features / changes This was a deprecated call to a no-op function. The function has now been removed in a newer version of the library. We need to support this newer library version to unblock an internal lsc Googlers see cl/771125806 I also needed to add a new source for the jsoup dependency. Previously this was being provided by the operating system (CI currently uses ubuntu 22.04 lts), but that version is now 3 years out of date.
diff --git a/tensorboard/java/org/tensorflow/tensorboard/vulcanize/BUILD b/tensorboard/java/org/tensorflow/tensorboard/vulcanize/BUILD
@@ -17,7 +17,7 @@ java_binary(
         "@com_google_protobuf//:protobuf_java",
         "@io_bazel_rules_closure//java/io/bazel/rules/closure:webpath",
         "@io_bazel_rules_closure//java/io/bazel/rules/closure/webfiles:build_info_java_proto",
-        "@org_jsoup",
+        "@org_jsoup_external",
     ],
 )
 
diff --git a/tensorboard/java/org/tensorflow/tensorboard/vulcanize/Vulcanize.java b/tensorboard/java/org/tensorflow/tensorboard/vulcanize/Vulcanize.java
@@ -460,9 +460,6 @@ private static Document getFlattenedHTML5Document(Document document) {
       }
     }
 
-    // Create `<html>`, `<head>` and `<body>`.
-    flatDoc.normalise();
-
     document.traverse(new FlatDocumentCopier(flatDoc));
 
     for (Element subdoc : flatDoc.getElementsByTag("#root")) {
diff --git a/third_party/workspace.bzl b/third_party/workspace.bzl
@@ -138,3 +138,14 @@ def tensorboard_workspace(name = ""):
         ],
         licenses = ["notice"],  # Apache 2.0
     )
+
+    java_import_external(
+        name = "org_jsoup_external",
+        jar_sha256 = "436adf71fe9f326e04fe134cd2785b261f0f4b9b60876adda1de3b6919463394",
+        jar_urls = [
+            "https://storage.googleapis.com/mirror.tensorflow.org/jsoup.org/packages/jsoup-1.21.1.jar",
+            "https://repo1.maven.org/maven2/org/jsoup/jsoup/1.21.1/jsoup-1.21.1.jar",
+            "https://jsoup.org/packages/jsoup-1.21.1.jar",
+        ],
+        licenses = ["notice"],  # MIT
+    )

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ java_binary(`
`17`	`17`	`"@com_google_protobuf//:protobuf_java",`
`18`	`18`	`"@io_bazel_rules_closure//java/io/bazel/rules/closure:webpath",`
`19`	`19`	`"@io_bazel_rules_closure//java/io/bazel/rules/closure/webfiles:build_info_java_proto",`
`20`		`- "@org_jsoup",`
	`20`	`+ "@org_jsoup_external",`
`21`	`21`	`],`
`22`	`22`	`)`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -460,9 +460,6 @@ private static Document getFlattenedHTML5Document(Document document) {`
`460`	`460`	`}`
`461`	`461`	`}`
`462`	`462`
`463`		- // Create `<html>`, `<head>` and `<body>`.
`464`		`- flatDoc.normalise();`
`465`		`-`
`466`	`463`	`document.traverse(new FlatDocumentCopier(flatDoc));`
`467`	`464`
`468`	`465`	`for (Element subdoc : flatDoc.getElementsByTag("#root")) {`