Skip to content

Commit bdaad84

Browse files
authored
cleanup: Remove test deps on //@npm//@angular/compiler. (#6074)
Remove seemingly unnecessary deps from test libraries on `//@npm//@angular/compiler`. Why these subset of tests have this dependency is unknown to me - none of the corresponding test files actually `import @angular/compiler;`. Looking at the generated bundles for these tests, the output appears only partially compiled (ie the bundled output is more akin to `//tensorboard:dev` than `//tensorboard`), but if the angular compiler is actually included by the test runtime then it is done somewhere deep in the test framework. Not sure if it is Karma or spec_bundle() or elsewhere. To test: * Run the tests. They pass. * Check I got all the instances in tests: ``` $ grep -r "angular/compiler" * defs/BUILD:# Custom ts_library compiler that runs tsc_wrapped with angular/compiler-cli statically linked defs/BUILD: "@npm//@angular/compiler-cli", webapp/dev_assets/BUILD: "@npm//@angular/compiler", webapp/dev_assets/main_dev.ts:import '@angular/compiler'; ```
1 parent 7819915 commit bdaad84

File tree

22 files changed

+0
-28
lines changed

22 files changed

+0
-28
lines changed

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ tf_ts_library(
7777
"//tensorboard/webapp/angular:expect_angular_core_testing",
7878
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
7979
"@npm//@angular/common",
80-
"@npm//@angular/compiler",
8180
"@npm//@angular/core",
8281
"@npm//@angular/platform-browser",
8382
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/effects/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ tf_ts_library(
4545
"//tensorboard/webapp/core/store",
4646
"//tensorboard/webapp/webapp_data_source:http_client_testing",
4747
"@npm//@angular/common",
48-
"@npm//@angular/compiler",
4948
"@npm//@angular/core",
5049
"@npm//@ngrx/effects",
5150
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/alerts/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ tf_ts_library(
4848
"//tensorboard/webapp/angular:expect_angular_core_testing",
4949
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
5050
"@npm//@angular/common",
51-
"@npm//@angular/compiler",
5251
"@npm//@angular/core",
5352
"@npm//@angular/platform-browser",
5453
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/debug_tensor_value/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ tf_ts_library(
3131
"//tensorboard/webapp/angular:expect_angular_core_testing",
3232
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
3333
"@npm//@angular/common",
34-
"@npm//@angular/compiler",
3534
"@npm//@angular/core",
3635
"@npm//@angular/platform-browser",
3736
"@npm//@types/jasmine",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ tf_ts_library(
5050
"//tensorboard/webapp/angular:expect_angular_core_testing",
5151
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
5252
"@npm//@angular/common",
53-
"@npm//@angular/compiler",
5453
"@npm//@angular/core",
5554
"@npm//@angular/platform-browser",
5655
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ tf_ts_library(
6161
"//tensorboard/webapp/angular:expect_angular_core_testing",
6262
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
6363
"@npm//@angular/common",
64-
"@npm//@angular/compiler",
6564
"@npm//@angular/core",
6665
"@npm//@angular/platform-browser",
6766
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ tf_ts_library(
6161
"//tensorboard/webapp/angular:expect_angular_core_testing",
6262
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
6363
"@npm//@angular/common",
64-
"@npm//@angular/compiler",
6564
"@npm//@angular/core",
6665
"@npm//@angular/platform-browser",
6766
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ tf_ts_library(
5858
"//tensorboard/webapp/widgets/source_code:load_monaco",
5959
"//tensorboard/webapp/widgets/source_code:testing",
6060
"@npm//@angular/common",
61-
"@npm//@angular/compiler",
6261
"@npm//@angular/core",
6362
"@npm//@angular/platform-browser",
6463
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ tf_ts_library(
5151
"//tensorboard/webapp/angular:expect_angular_core_testing",
5252
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
5353
"@npm//@angular/common",
54-
"@npm//@angular/compiler",
5554
"@npm//@angular/core",
5655
"@npm//@angular/platform-browser",
5756
"@npm//@ngrx/store",

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/timeline/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ tf_ts_library(
4545
"//tensorboard/webapp/angular:expect_angular_core_testing",
4646
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
4747
"@npm//@angular/common",
48-
"@npm//@angular/compiler",
4948
"@npm//@angular/core",
5049
"@npm//@angular/platform-browser",
5150
"@npm//@ngrx/store",

0 commit comments

Comments
 (0)