Skip to content

Commit dd31415

Browse files
authored
Embedded Single Card: Card route type parse experiment IDs (#6482)
Add handling to parse experiment IDs for card route `tb.corp/card/<exp_ids>/tag/<tag>` .
1 parent fc1c0b5 commit dd31415

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

tensorboard/webapp/app_routing/internal_utils.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,13 @@ export function getExperimentIdsFromRouteParams(
7474
}
7575
return [DEFAULT_EXPERIMENT_ID];
7676
}
77+
case RouteKind.CARD: {
78+
const experimentIds = (params as CompareRouteParams).experimentIds;
79+
if (experimentIds.indexOf(',') < 0) {
80+
return [experimentIds];
81+
}
82+
return parseCompareExperimentStr(experimentIds).map(({id}) => id);
83+
}
7784
case RouteKind.COMPARE_EXPERIMENT: {
7885
const typedParams = params as CompareRouteParams;
7986
return parseCompareExperimentStr(typedParams.experimentIds).map(

tensorboard/webapp/app_routing/internal_utils_test.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,20 @@ describe('app_routing/utils', () => {
108108
expect(actual).toEqual(['1', '2']);
109109
});
110110

111+
it('returns single id from card route', () => {
112+
const actual = utils.getExperimentIdsFromRouteParams(RouteKind.CARD, {
113+
experimentIds: '111',
114+
});
115+
expect(actual).toEqual(['111']);
116+
});
117+
118+
it('returns multiple ids from card route', () => {
119+
const actual = utils.getExperimentIdsFromRouteParams(RouteKind.CARD, {
120+
experimentIds: 'e1:111,e2:222',
121+
});
122+
expect(actual).toEqual(['111', '222']);
123+
});
124+
111125
it('returns id from experiment route', () => {
112126
const actual = utils.getExperimentIdsFromRouteParams(
113127
RouteKind.EXPERIMENT,

0 commit comments

Comments
 (0)