Skip to content

Commit e831ddb

Browse files
authored
Embedding Projector: fix status bar display (#6312)
## Motivation for features / changes fix status bar display ## Technical description of changes Status bar is always hidden, change it so it shows appropriately ## Screenshots of UI changes Before: ![image](https://user-images.githubusercontent.com/31378877/232665924-8385dc3e-82e2-4680-8a06-0f2f090a34a4.png) After: ![image](https://user-images.githubusercontent.com/31378877/232665977-2177dd2a-7d7b-4d55-9fe9-d190b7081c8a.png) ## Detailed steps to verify changes work correctly (as executed by you) hover over a point and verify status bar changes ## Alternate designs / implementations considered
1 parent f7d8e64 commit e831ddb

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tensorboard/plugins/projector/vz_projector/vz-projector.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,8 @@ class Projector
588588
}
589589
if (this.selectedPointIndices.length === 0) {
590590
if (hoverText) {
591-
this.statusBar.innerText = hoverText!;
591+
this.statusBar.innerText = hoverText;
592+
this.statusBar.style.display = null!;
592593
} else {
593594
this.statusBar.style.display = 'none';
594595
}
@@ -611,6 +612,8 @@ class Projector
611612
this.selectedPointIndices.length + neighborsOfFirstPoint.length;
612613
this.statusBar.innerText = `Selected ${totalNumPoints} points`;
613614
if (totalNumPoints > 0) {
615+
this.statusBar.style.display = null!;
616+
} else {
614617
this.statusBar.style.display = 'none';
615618
}
616619
}

0 commit comments

Comments
 (0)