Skip to content

Commit 00831de

Browse files
authored
Update iOS and OSX versions for testing (#8023)
* update versions * upd * upd * upd * Update karma.conf.js
1 parent 349cf63 commit 00831de

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

e2e/karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ module.exports = function(config) {
182182
browser: 'safari',
183183
browser_version: 'latest',
184184
os: 'OS X',
185-
os_version: 'High Sierra'
185+
os_version: 'Mojave'
186186
},
187187
bs_ios_12: {
188188
base: 'BrowserStack',

e2e/script_tag_tests/tfjs-core-cpu/karma.conf.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ module.exports = function(config) {
9595
browser: 'safari',
9696
browser_version: 'latest',
9797
os: 'OS X',
98-
os_version: 'High Sierra'
98+
os_version: 'Mojave'
9999
},
100100
bs_ios_12: {
101101
base: 'BrowserStack',
102102
device: 'iPhone X',
103103
os: 'iOS',
104-
os_version: '11.0',
104+
os_version: '12.3',
105105
real_mobile: true
106106
},
107107
bs_android_10: {

e2e/script_tag_tests/tfjs/karma.conf.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,13 @@ module.exports = function(config) {
8787
browser: 'safari',
8888
browser_version: 'latest',
8989
os: 'OS X',
90-
os_version: 'High Sierra'
90+
os_version: 'Mojave'
9191
},
9292
bs_ios_12: {
9393
base: 'BrowserStack',
9494
device: 'iPhone X',
9595
os: 'iOS',
96-
os_version: '11.0',
96+
os_version: '12.3',
9797
real_mobile: true
9898
},
9999
bs_android_10: {

tools/karma_template.conf.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const CUSTOM_LAUNCHERS = {
5353
browser: 'safari',
5454
browser_version: 'latest',
5555
os: 'OS X',
56-
os_version: 'High Sierra'
56+
os_version: 'Mojave'
5757
},
5858
bs_ios_12: {
5959
base: 'BrowserStack',
@@ -173,7 +173,8 @@ module.exports = function(config) {
173173
// This is necessary for non-flaky Safari tests. They usually pass just
174174
// fine without it, but sometimes, Safari will fail to connect to Karma.
175175
// If you want to remove this, prove that it's not flaky by running
176-
// bazel test //tfjs-core/src:bs_safari_mac_from_pixels_worker_test --runs_per_test=100
176+
// bazel test //tfjs-core/src:bs_safari_mac_from_pixels_worker_test
177+
// --runs_per_test=100
177178
extraConfig.hostname = 'bs-local.com';
178179
}
179180

0 commit comments

Comments
 (0)