refactor: replace deprecated String.prototype.substr() (#6255)

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <[email protected]>

Co-authored-by: Na Li <[email protected]>

Author: CommanderRoot

scripts/release-util.ts

@@ -279,7 +279,7 @@ export async function updateDependency(
 
       let relaxedVersionPrefix = '';
       if (version.startsWith('~') || version.startsWith('^')) {
-        relaxedVersionPrefix = version.substr(0, 1);
+        relaxedVersionPrefix = version.slice(0, 1);
       }
       const depVersionLatest = relaxedVersionPrefix + depsLatestVersion[j];
 
@@ -337,7 +337,7 @@ export function updateTFJSDependencyVersions(
 
     let relaxedVersionPrefix = '';
     if (version.startsWith('~') || version.startsWith('^')) {
-      relaxedVersionPrefix = version.substr(0, 1);
+      relaxedVersionPrefix = version.slice(0, 1);
     }
     const versionLatest = relaxedVersionPrefix + newVersion;
 

scripts/tag-version.js

@@ -22,7 +22,7 @@ const fs = require('fs');
 
 let dirName = process.argv[2];
 if (dirName.endsWith('/')) {
-  dirName = dirName.substr(0, dirName.length - 1);
+  dirName = dirName.slice(0, -1);
 }
 const packageJsonFile = dirName + '/package.json';
 if (!fs.existsSync(packageJsonFile)) {

tfjs-converter/src/operations/operation_mapper.ts

@@ -191,7 +191,7 @@ export class OperationMapper {
       category: mapper.category,
       inputNames:
           (node.input ||
-           []).map(input => input.startsWith('^') ? input.substr(1) : input),
+           []).map(input => input.startsWith('^') ? input.slice(1) : input),
       inputs: [],
       children: [],
       inputParams: {},

tfjs-data/src/sources/file_data_source.ts

@@ -46,7 +46,7 @@ export class FileDataSource extends DataSource {
     if (isLocalPath(this.input) && env().get('IS_NODE')) {
       // tslint:disable-next-line:no-require-imports
       const fs = require('fs');
-      this.input = fs.readFileSync((this.input as string).substr(7));
+      this.input = fs.readFileSync((this.input as string).slice(7));
     }
     // TODO(kangyizhang): Add LocalFileChunkIterator to split local streaming
     // with file in browser.

tfjs-data/src/util/source_util.ts

@@ -20,5 +20,5 @@
 // input.
 // tslint:disable-next-line:no-any
 export function isLocalPath(source: any): boolean {
-  return (typeof source === 'string') && source.substr(0, 7) === 'file://';
+  return (typeof source === 'string') && source.slice(0, 7) === 'file://';
 }

tfjs-layers/src/engine/topology.ts

@@ -1232,7 +1232,7 @@ export abstract class Layer extends serialization.Serializable {
         // TODO(cais): Restore the following and use `providedWeights`, instead
         // of `weights` in the error message, once the deeplearn.js bug is
         // fixed: https://github.com/PAIR-code/deeplearnjs/issues/498 const
-        // providedWeights = JSON.stringify(weights).substr(0, 50);
+        // providedWeights = JSON.stringify(weights).slice(0, 50);
         throw new ValueError(
             `You called setWeights(weights) on layer "${this.name}" ` +
             `with a weight list of length ${weights.length}, ` +

tfjs-node/scripts/deps-stage.js

@@ -40,7 +40,7 @@ if (os.platform() !== 'win32') {
 
 // Some windows machines contain a trailing " char:
 if (targetDir != undefined && targetDir.endsWith('"')) {
-  targetDir = targetDir.substr(0, targetDir.length - 1);
+  targetDir = targetDir.slice(0, -1);
 }
 
 // Setup dest binary paths: