support completion of a tensor with a dimensionally-compatible (not necessarily equal) tensor.

Author: michi42

src/java/org/tensorics/core/tensor/lang/TensorStructurals.java

@@ -170,10 +170,7 @@ public static final <S> OngoingTensorFiltering<S> filter(Tensor<S> tensor) {
 
     public static final <S> Tensor<S> completeWith(Tensor<S> tensor, Tensor<S> second) {
         checkNotNull(second, "second tensor must not be null");
-        checkArgument(second.shape().dimensionSet().equals(tensor.shape().dimensionSet()),
-                "Tensors do not have the same dimensions! Completion not supported! Dimensions of tensor to complete: "
-                        + tensor.shape().dimensionSet() + "; Dimensions of tensor for completion: "
-                        + second.shape().dimensionSet());
+
         Builder<S> builder = ImmutableTensor.builder(tensor.shape().dimensionSet());
         builder.context(tensor.context());
 

src/test/org/tensorics/core/tensor/CoordinateClassHierarchyTest.java

@@ -91,10 +91,15 @@ public void canAddTensorsWithEqualDimensionsAndIncompatibleLeafCoordinates() {
     }
 
     @Test
-    public void canCompleteTensorsWithCompatibleDimensionsAndIncompatibleLeafCoordinates() {
+    public void canCompleteTensorsWithEqualDimensionsAndIncompatibleLeafCoordinates() {
         Tensorics.complete(compatibleInterfaceTensor).with(incompatibleInterfaceTensor);
     }
 
+    @Test
+    public void canCompleteTensorsWithCompatibleDimensionsAndIncompatibleLeafCoordinates() {
+        Tensorics.complete(compatibleInterfaceTensor).with(incompatibleLeafTensor);
+    }
+
     @Test
     public void canAddTensorsWithEqualDimensionsAndPartiallyIncompatibleLeafCoordinates() {
         Tensor<Double> mixedInterfaceTensor = Tensorics.complete(compatibleInterfaceTensor)