bh_chip: add error logging to therm trip and pgood gpio setups

Enable logging for bh_chip in case there are any errors in setting up the therm
trip or pgood gpios.

Also remove unused function declaration from bh_chip.h.

Signed-off-by: Petra Alexson <[email protected]>

Author: kikkiakki

include/tenstorrent/bh_chip.h

@@ -141,8 +141,6 @@ int bh_chip_reset_chip(struct bh_chip *chip, bool force_reset);
 int therm_trip_gpio_setup(struct bh_chip *chip);
 int pgood_gpio_setup(struct bh_chip *chip);
 
-void pgood_fault_work_handler(struct k_work *work);
-
 #ifdef __cplusplus
 }
 #endif

lib/tenstorrent/bh_chip/bh_chip.c

@@ -10,6 +10,10 @@
 #include <tenstorrent/fan_ctrl.h>
 #include <tenstorrent/event.h>
 #include <zephyr/kernel.h>
+#include <zephyr/logging/log.h>
+#include <string.h>
+
+LOG_MODULE_REGISTER(bh_chip, CONFIG_TT_BH_CHIP_LOG_LEVEL);
 
 void bh_chip_cancel_bus_transfer_set(struct bh_chip *dev)
 {
@@ -126,15 +130,20 @@ int therm_trip_gpio_setup(struct bh_chip *chip)
 
 	ret = gpio_pin_configure_dt(&chip->config.therm_trip, GPIO_INPUT);
 	if (ret != 0) {
+		LOG_ERR("%s() failed: %d", "gpio_pin_configure_dt", ret);
 		return ret;
 	}
 	gpio_init_callback(&chip->therm_trip_cb, therm_trip_detected,
 			   BIT(chip->config.therm_trip.pin));
 	ret = gpio_add_callback_dt(&chip->config.therm_trip, &chip->therm_trip_cb);
 	if (ret != 0) {
+		LOG_ERR("%s() failed: %d", "gpio_add_callback_dt", ret);
 		return ret;
 	}
 	ret = gpio_pin_interrupt_configure_dt(&chip->config.therm_trip, GPIO_INT_EDGE_TO_ACTIVE);
+	if (ret != 0) {
+		LOG_ERR("%s() failed: %d", "gpio_pin_interrupt_configure_dt", ret);
+	}
 
 	return ret;
 }
@@ -160,15 +169,19 @@ int pgood_gpio_setup(struct bh_chip *chip)
 
 	ret = gpio_pin_configure_dt(&chip->config.pgood, GPIO_INPUT);
 	if (ret != 0) {
+		LOG_ERR("%s() failed: %d", "gpio_pin_configure_dt", ret);
 		return ret;
 	}
 	gpio_init_callback(&chip->pgood_cb, pgood_change_detected, BIT(chip->config.pgood.pin));
 	ret = gpio_add_callback_dt(&chip->config.pgood, &chip->pgood_cb);
 	if (ret != 0) {
+		LOG_ERR("%s() failed: %d", "gpio_add_callback_dt", ret);
 		return ret;
 	}
-
 	ret = gpio_pin_interrupt_configure_dt(&chip->config.pgood, GPIO_INT_EDGE_BOTH);
+	if (ret != 0) {
+		LOG_ERR("%s() failed: %d", "gpio_pin_interrupt_configure_dt", ret);
+	}
 
 	return ret;
 }