Skip to content
This repository was archived by the owner on Dec 30, 2023. It is now read-only.

Commit 2cb9e45

Browse files
authored
fix(number): ♻ Rename isNaN() to isItNaN() (#70)
1 parent 42b57fb commit 2cb9e45

File tree

7 files changed

+294
-268
lines changed

7 files changed

+294
-268
lines changed

.changeset/khaki-clocks-retire.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@terminal-nerds/snippets-number": patch
3+
---
4+
5+
♻ Rename `isNaN()` to `isItNaN()` to silence the SonarQube issue

.npmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/array/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"test:unit": "vitest run --dir \"./source\""
6969
},
7070
"peerDependencies": {
71-
"typescript": "4.9.5"
71+
"typescript": "5.0.2"
7272
},
7373
"devDependencies": {
7474
"@terminal-nerds/snippets-test": "workspace:*"

packages/number/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"test:unit": "vitest run --dir \"./source\""
6969
},
7070
"peerDependencies": {
71-
"typescript": "4.9.5"
71+
"typescript": "5.0.2"
7272
},
7373
"devDependencies": {
7474
"@terminal-nerds/snippets-test": "workspace:*"

packages/number/source/schema/groups/nan/nan.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { returns, throws } from "@terminal-nerds/snippets-test/unit";
44
import { describe, expect, it } from "vitest";
55
import { ZodError } from "zod";
66

7-
import { isNaN, validateNaN } from "./nan.ts";
7+
import { isItNaN, validateNaN } from "./nan.ts";
88

99
const SAMPLE_NON_NANS = SAMPLE_NUMBERS.filter((n) => !Number.isNaN(n));
1010

@@ -22,16 +22,16 @@ describe("validateNaN(value)", () => {
2222
});
2323
});
2424

25-
describe("isNaN(value)", () => {
25+
describe("isItNaN(value)", () => {
2626
it(returns(false).on(`non-NaN`).samples(SAMPLE_NON_NANS), () => {
2727
for (const nonNaNSample of SAMPLE_NON_NANS) {
28-
expect(isNaN(nonNaNSample)).toBe(false);
28+
expect(isItNaN(nonNaNSample)).toBe(false);
2929
}
3030
});
3131

3232
it(returns(true).on(`NaN`).samples(SAMPLE_NANS), () => {
3333
for (const infinitySample of SAMPLE_NANS) {
34-
expect(isNaN(infinitySample)).toBe(true);
34+
expect(isItNaN(infinitySample)).toBe(true);
3535
}
3636
});
3737
});

packages/number/source/schema/groups/nan/nan.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ export function validateNaN(value: number): asserts value is NaN {
88
NAN_SCHEMA.parse(value);
99
}
1010

11-
export function isNaN(value: number): value is NaN {
11+
export function isItNaN(value: number): value is NaN {
1212
return NAN_SCHEMA.safeParse(value).success;
1313
}

0 commit comments

Comments
 (0)