WOQL.literal(0, 'xsd:double') drops @type: DataValue when val is 0

[wcoolidge]

WOQL.literal(0, 'xsd:double') for val of 0 generates:

{
              "@type": "xsd:double",
              "@value": 0
}

instead of:

{
          "@type": "DataValue",
          "data": {
            "@type": "xsd:double",
            "@value": 0
          }
 }

This is done with terminusdb 11.1.12, "@terminusdb/terminusdb-client": "10.0.33", under typescript.
SWI-Prolog version 9.2.9 for x86_64-linux

[hoijnet]

Hi, thanks for the report. We have started to look into this and the other one!

[hoijnet]

Will transfer this issue to the javascript client, where a fix is due.

[hoijnet]

@wcoolidge , finally got around to checking this in more detail.

eq("v:var", literal(1, 'xsd:double'))

Yields the following WOQL AST json with the client:

{
  "@type": "Equals",
  "left": {
    "@type": "Value",
    "variable": "var"
  },
  "right": {
    "@type": "Value",
    "data": {
      "@type": "xsd:double",
      "@value": 1
    }
  }
}

Using 0 or 1 both yield the same structure. Could you elaborate a bit more. Please use the template below for a bug report if possible to make sure I understand the difference in expectation. The literal is contextual and thus depend a little on where it is applied. Could you show a case that works as you expect, and a case that does not work as you expect (the different structures between 0 and maybe 1 as an example?).

What are you trying to accomplish and do you have a minimum reproducible example on what is not as expected?

I will close the issue for now as I can't reproduce an errors. Please re-open once more information is available. It looks to be a javascript client-related issue.

---

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Info (please complete the following information):

• OS: [e.g. Ubuntu 18.04]
• How did you run terminus-server (terminus-quickstart, using Docker directly, manual installation)
• SWI Prolog version if you're using the manual installation

Additional context
Add any other context about the problem here.

[wcoolidge]

Describe the bug

    The inequality equals (WOQL.eq) matches for other data types, but not for xsd:double. 

    The inequality equals matches for xsd:double on an element of an xsd:double Array.

    A plain query on xsd:double values match without the indirection of WQOL.eq.

    The generated JSON-LD code for the query looks fine! 

Yes, I agree and am sorry about the original bug submission, I think we have to write that submission off!

To Reproduce

Steps to reproduce the behavior:

Test code (matchInequalities) for reproducing the bug included below.

test case:

        schema with a type with literal object type values defined for xsd:double, xsd:integer, xsd:string

        db populated with an instance where the xsd:double value is 10

Inequalities ">", "<" work for double, integer:

The inequality "==" works for integer and string:

              const working = matchInequalities('hasCurrent','<', 11, "xsd:double");      // matches
              const working = matchInequalities('hasCurrent','>', 9, "xsd:double");       // matches

              const working = matchInequalities('count','==', 1, "xsd:integer");          // matches
              const working = matchInequalities('first','==', "0", "xsd:string");         // matches

Inequality "==" does not match for xsd:double

              const working = matchInequalities('hasCurrent','==', 10.0, "xsd:double");   // no match
              const working = matchInequalities('hasCurrent','==', 10, "xsd:double");     // no match

Note: the inequality "==" works for xsd:double in an Array (where ">" does not in matchArrayInequality below)!

        const matchInequalities = (predicate, operand, valueToMatch, literalType) => {
          /*
              Preconditions:
                  schema type(s)/data instances with a predicate to a literal of type literaType
                  operand of either >, <, ==
                  valueToMatch is value to match in equality (rhs)
          */
          const inequalityFunc = (symbol) => {
            let woql;
            switch (symbol) {
              case '==':
                woql = WOQL.eq
                break;
              case '>':
                woql = WOQL.greater
                break;
              case '<':
                woql = WOQL.less
                break;
            }
            return woql;
          }
         
          const [uri, doc, val] = WOQL.vars("uri", "doc","val");
          const woql = inequalityFunc(operand)

          const q = WOQL.limit(1).select(uri, doc).and(
            WOQL.triple(uri, `@schema:${predicate}`, val),
           
            woql(val, WOQL.literal(valueToMatch, literalType)),
          
            WOQL.read_document(uri, doc)
          )
          return q;
        }

const matchArrayInequalities = (predicate, operand, index, valueToMatch, arrType) => {
          /*
              Preconditions:
                  schema type(s)/data instances with a predicate to a literal array (1D) of type arrType
                  operand of either >, <, ==
                  index of element index in predicate's literal array of type arrType to match
                  valueToMatch is value to match in equality (rhs)
          */
          const inequalityFunc = (symbol) => {
            let woql;
            switch (symbol) {
              case '==':
                woql = WOQL.eq
                break;
              case '>':
                woql = WOQL.greater
                break;
              case '<':
                woql = WOQL.less
                break;
            }
            return woql;
          }
         
          const [uri, doc, arr, val] = WOQL.vars("uri", "doc", `arr${index}`, `val${index}`);
          const woql = inequalityFunc(operand)

          const q = WOQL.limit(1).select(uri, doc).and(
            WOQL.triple(uri, `@schema:${predicate}`, arr),
            WOQL.triple(arr, "sys:index", WOQL.literal(index.toString(), "xsd:nonNegativeInteger")),
            woql(val, WOQL.literal(valueToMatch, arrType)),
            WOQL.triple(arr, "sys:value", val),
            WOQL.read_document(uri, doc)
          )
          return q;
        }
         

Expected behavior

expect a match on WOQL.eq

Screenshots

not applicable

Info (please complete the following information):

OS: ubuntu 22.04
How did you run terminus-server: manual: terminusdb 11.1.12, 
"@terminusdb/terminusdb-client": "10.0.33", 
under typescript.
SWI-Prolog version 9.2.9 for x86_64-linux

Additional context

appears related to xsd:double failure for WQOL.greater in an array (as reproduced in matchArrayInequalities)

[wcoolidge]

verified as resolved in 11_2_rc1

[hoijnet]

Great to hearing that! Thanks for the feedback @wcoolidge !!